Drop ROMCC code and header guards

Change-Id: I730f80afd8aad250f26534435aec24bea75a849c
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37334
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>

20 files changed, 8 insertions, 109 deletions

diff --git a/src/include/console/console.h b/src/include/console/console.h
index 607c96862e..583420cb83 100644
--- a/src/include/console/console.h
+++ b/src/include/console/console.h
@@ -26,8 +26,6 @@
 #define RAM_DEBUG (CONFIG(DEBUG_RAM_SETUP) ? BIOS_DEBUG : BIOS_NEVER)
 #define RAM_SPEW  (CONFIG(DEBUG_RAM_SETUP) ? BIOS_SPEW  : BIOS_NEVER)
 
-#ifndef __ROMCC__
-
 #include <console/vtxprintf.h>
 
 void post_code(u8 value);
@@ -101,11 +99,4 @@ int do_printk(int msg_level, const char *fmt, ...)
 
 int do_vprintk(int msg_level, const char *fmt, va_list args);
 
-#else
-
-static inline void romcc_printk(void) { }
-#define printk(...) romcc_printk()
-
-#endif /* !__ROMCC__ */
-
 #endif /* CONSOLE_CONSOLE_H_ */
diff --git a/src/include/console/uart.h b/src/include/console/uart.h
index aed67c2c7b..162b1108a9 100644
--- a/src/include/console/uart.h
+++ b/src/include/console/uart.h
@@ -55,7 +55,6 @@ unsigned char uart_rx_byte(int idx);
 
 uintptr_t uart_platform_base(int idx);
 
-#if !defined(__ROMCC__)
 static inline void *uart_platform_baseptr(int idx)
 {
 	return (void *)uart_platform_base(idx);
@@ -100,6 +99,4 @@ static inline u8 __gdb_rx_byte(void)
 }
 #endif
 
-#endif /* __ROMCC__ */
-
 #endif /* CONSOLE_UART_H */
diff --git a/src/include/cpu/amd/mtrr.h b/src/include/cpu/amd/mtrr.h
index edbf7bb2aa..906a7c00f0 100644
--- a/src/include/cpu/amd/mtrr.h
+++ b/src/include/cpu/amd/mtrr.h
@@ -38,7 +38,7 @@
 #define TOP_MEM_MASK			0x007fffff
 #define TOP_MEM_MASK_KB			(TOP_MEM_MASK >> 10)
 
-#if !defined(__ROMCC__) && !defined(__ASSEMBLER__)
+#if !defined(__ASSEMBLER__)
 
 #include <cpu/x86/msr.h>
 
diff --git a/src/include/cpu/x86/cache.h b/src/include/cpu/x86/cache.h
index 713ca323a8..0331e27161 100644
--- a/src/include/cpu/x86/cache.h
+++ b/src/include/cpu/x86/cache.h
@@ -23,28 +23,11 @@
 
 #if !defined(__ASSEMBLER__)
 
-/*
- * Need two versions because ROMCC chokes on certain clobbers:
- * cache.h:29.71: cache.h:60.24: earlymtrr.c:117.23: romstage.c:144.33:
- * 0x1559920 asm        Internal compiler error: lhs 1 regcm == 0
- */
-
-#if defined(__GNUC__)
-
 static inline void wbinvd(void)
 {
 	asm volatile ("wbinvd" ::: "memory");
 }
 
-#else
-
-static inline void wbinvd(void)
-{
-	asm volatile ("wbinvd");
-}
-
-#endif
-
 static inline void invd(void)
 {
 	asm volatile("invd" ::: "memory");
diff --git a/src/include/cpu/x86/cr.h b/src/include/cpu/x86/cr.h
index 0f14d5451d..0339aa3937 100644
--- a/src/include/cpu/x86/cr.h
+++ b/src/include/cpu/x86/cr.h
@@ -20,12 +20,7 @@
 
 #include <stdint.h>
 
-/* ROMCC apparently chokes certain clobber registers. */
-#if defined(__ROMCC__)
-#define COMPILER_BARRIER
-#else
 #define COMPILER_BARRIER "memory"
-#endif
 
 #ifdef __x86_64__
 #define CRx_TYPE uint64_t
diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h
index 2710e7f1fc..63cb8bde28 100644
--- a/src/include/cpu/x86/msr.h
+++ b/src/include/cpu/x86/msr.h
@@ -81,21 +81,6 @@
 
 #ifndef __ASSEMBLER__
 #include <types.h>
-#if defined(__ROMCC__)
-
-typedef __builtin_msr_t msr_t;
-
-static msr_t rdmsr(unsigned long index)
-{
-	return __builtin_rdmsr(index);
-}
-
-static void wrmsr(unsigned long index, msr_t msr)
-{
-	__builtin_wrmsr(index, msr.lo, msr.hi);
-}
-
-#else
 
 typedef struct msr_struct {
 	unsigned int lo;
@@ -154,7 +139,6 @@ static __always_inline void wrmsr(unsigned int index, msr_t msr)
 }
 
 #endif /* CONFIG_SOC_SETS_MSRS */
-#endif /* __ROMCC__ */
 
 /* Helpers for interpreting MC[i]_STATUS */
 
diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h
index 29256c8d46..07db3cb606 100644
--- a/src/include/cpu/x86/mtrr.h
+++ b/src/include/cpu/x86/mtrr.h
@@ -53,7 +53,7 @@
 #define MTRR_FIX_4K_F0000		0x26e
 #define MTRR_FIX_4K_F8000		0x26f
 
-#if !defined(__ASSEMBLER__) && !defined(__ROMCC__)
+#if !defined(__ASSEMBLER__)
 
 #include <stdint.h>
 #include <stddef.h>
@@ -140,9 +140,9 @@ static inline unsigned int fls(unsigned int x)
 		"1:" : "=r" (r) : "mr" (x));
 	return r;
 }
-#endif /* !defined(__ASSEMBLER__) && !defined(__ROMCC__) */
+#endif /* !defined(__ASSEMBLER__) */
 
-/* Align up/down to next power of 2, suitable for ROMCC and assembler
+/* Align up/down to next power of 2, suitable for assembler
    too. Range of result 256kB to 128MB is good enough here. */
 #define _POW2_MASK(x)	((x>>1)|(x>>2)|(x>>3)|(x>>4)|(x>>5)| \
 					(x>>6)|(x>>7)|(x>>8)|((1<<18)-1))
diff --git a/src/include/cpu/x86/tsc.h b/src/include/cpu/x86/tsc.h
index c18f8782f0..6943b93018 100644
--- a/src/include/cpu/x86/tsc.h
+++ b/src/include/cpu/x86/tsc.h
@@ -28,7 +28,6 @@ static inline tsc_t rdtsc(void)
 	return res;
 }
 
-#if !defined(__ROMCC__)
 /* Simple 32- to 64-bit multiplication. Uses 16-bit words to avoid overflow.
  * This code is used to prevent use of libgcc's umoddi3.
  */
@@ -42,7 +41,6 @@ static inline void multiply_to_tsc(tsc_t *const tsc, const u32 a, const u32 b)
 	tsc->hi = ((a >> 16) * (b >> 16)) + (tsc->hi >> 16);
 }
 
-/* Too many registers for ROMCC */
 static inline unsigned long long rdtscll(void)
 {
 	unsigned long long val;
@@ -58,7 +56,6 @@ static inline uint64_t tsc_to_uint64(tsc_t tstamp)
 {
 	return (((uint64_t)tstamp.hi) << 32) + tstamp.lo;
 }
-#endif
 
 /* Provided by CPU/chipset code for the TSC rate in MHz. */
 unsigned long tsc_freq_mhz(void);
diff --git a/src/include/device/device.h b/src/include/device/device.h
index abcd0a453a..e391291084 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -2,13 +2,6 @@
 
 #define DEVICE_H
 
-/*
- * NOTICE: Header is ROMCC tentative.
- * This header is incompatible with ROMCC and its inclusion leads to 'odd'
- * build failures.
- */
-#if !defined(__ROMCC__)
-
 #include <device/resource.h>
 #include <device/path.h>
 #include <device/pci_type.h>
@@ -330,6 +323,4 @@ void scan_smbus(struct device *bus);
 void scan_generic_bus(struct device *bus);
 void scan_static_bus(struct device *bus);
 
-#endif /* !defined(__ROMCC__) */
-
 #endif /* DEVICE_H */
diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h
index 4007cff7c3..524284a077 100644
--- a/src/include/device/mmio.h
+++ b/src/include/device/mmio.h
@@ -37,7 +37,6 @@
 #define clrbits32(addr, clear)		clrsetbits32(addr, clear, 0)
 #define clrbits64(addr, clear)		clrsetbits64(addr, clear, 0)
 
-#ifndef __ROMCC__
 /*
  * Reads a transfer buffer from 32-bit FIFO registers. fifo_stride is the
  * distance in bytes between registers (e.g. pass 4 for a normal array of 32-bit
@@ -195,6 +194,4 @@ static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo,
 #define READ32_BITFIELD(addr, name) \
 	EXTRACT_BITFIELD(read32(addr), name)
 
-#endif	/* !__ROMCC__ */
-
 #endif	/* __DEVICE_MMIO_H__ */
diff --git a/src/include/device/pci_mmio_cfg.h b/src/include/device/pci_mmio_cfg.h
index 30945f4c27..aa159705d1 100644
--- a/src/include/device/pci_mmio_cfg.h
+++ b/src/include/device/pci_mmio_cfg.h
@@ -20,7 +20,6 @@
 #include <device/mmio.h>
 #include <device/pci_type.h>
 
-#if !defined(__ROMCC__)
 
 /* By not assigning this to CONFIG_MMCONF_BASE_ADDRESS here we
  * prevent some sub-optimal constant folding. */
@@ -110,8 +109,6 @@ uint32_t *pci_mmio_config32_addr(pci_devfn_t dev, uint16_t reg)
 	return (uint32_t *)&pcicfg(dev)->reg32[reg / sizeof(uint32_t)];
 }
 
-#endif /* !defined(__ROMCC__) */
-
 #if CONFIG(MMCONF_SUPPORT)
 
 #if CONFIG_MMCONF_BASE_ADDRESS == 0
diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h
index 9d64f037f6..805c087de7 100644
--- a/src/include/device/pci_ops.h
+++ b/src/include/device/pci_ops.h
@@ -23,7 +23,6 @@
 #include <device/pci_type.h>
 #include <arch/pci_ops.h>
 
-#ifndef __ROMCC__
 void __noreturn pcidev_die(void);
 
 static __always_inline pci_devfn_t pcidev_bdf(const struct device *dev)
@@ -37,7 +36,6 @@ static __always_inline pci_devfn_t pcidev_assert(const struct device *dev)
 		pcidev_die();
 	return pcidev_bdf(dev);
 }
-#endif
 
 #if defined(__SIMPLE_DEVICE__)
 #define ENV_PCI_SIMPLE_DEVICE 1
@@ -184,7 +182,6 @@ void pci_update_config32(const struct device *dev, u16 reg, u32 mask, u32 or)
 u16 pci_s_find_next_capability(pci_devfn_t dev, u16 cap, u16 last);
 u16 pci_s_find_capability(pci_devfn_t dev, u16 cap);
 
-#ifndef __ROMCC__
 static __always_inline
 u16 pci_find_next_capability(const struct device *dev, u16 cap, u16 last)
 {
@@ -196,6 +193,5 @@ u16 pci_find_capability(const struct device *dev, u16 cap)
 {
 	return pci_s_find_capability(PCI_BDF(dev), cap);
 }
-#endif
 
 #endif /* PCI_OPS_H */
diff --git a/src/include/endian.h b/src/include/endian.h
index f16f668a18..0f32b7484a 100644
--- a/src/include/endian.h
+++ b/src/include/endian.h
@@ -79,7 +79,6 @@
 #define clrsetbits_le16(addr, clear, set) __clrsetbits(le, 16, addr, clear, set)
 #define clrsetbits_be16(addr, clear, set) __clrsetbits(be, 16, addr, clear, set)
 
-#ifndef __ROMCC__
 /* be16dec/be32dec/be64dec/le16dec/le32dec/le64dec family of functions. */
 #define DEFINE_ENDIAN_DEC(endian, width) \
 	static inline uint##width##_t endian##width##dec(const void *p) \
@@ -169,6 +168,5 @@ static inline uint64_t le64toh(uint64_t little_endian_64bits)
 {
 	return le64_to_cpu(little_endian_64bits);
 }
-#endif
 
 #endif
diff --git a/src/include/halt.h b/src/include/halt.h
index 117c6c087a..e2aa11cb6f 100644
--- a/src/include/halt.h
+++ b/src/include/halt.h
@@ -17,14 +17,10 @@
 #ifndef __HALT_H__
 #define __HALT_H__
 
-#ifdef __ROMCC__
-#include <lib/halt.c>
-#else
 /**
  * halt the system reliably
  */
 void __noreturn halt(void);
-#endif /* __ROMCC__ */
 
 /* Power off the system. */
 void poweroff(void);
diff --git a/src/include/lib.h b/src/include/lib.h
index 098d62df52..d1bbe93a37 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -57,14 +57,12 @@ void hexdump32(char LEVEL, const void *d, size_t len);
  */
 size_t hexstrtobin(const char *str, uint8_t *buf, size_t len);
 
-#if !defined(__ROMCC__)
 /* Count Leading Zeroes: clz(0) == 32, clz(0xf) == 28, clz(1 << 31) == 0 */
 static inline int clz(u32 x) { return x ? __builtin_clz(x) : sizeof(x) * 8; }
 /* Integer binary logarithm (rounding down): log2(0) == -1, log2(5) == 2 */
 static inline int log2(u32 x) { return sizeof(x) * 8 - clz(x) - 1; }
 /* Find First Set: __ffs(1) == 0, __ffs(0) == -1, __ffs(1<<31) == 31 */
 static inline int __ffs(u32 x) { return log2(x & (u32)(-(s32)x)); }
-#endif
 
 /* Integer binary logarithm (rounding up): log2_ceil(0) == -1, log2(5) == 3 */
 static inline int log2_ceil(u32 x) { return (x == 0) ? -1 : log2(x * 2 - 1); }
diff --git a/src/include/stdbool.h b/src/include/stdbool.h
index 2eeb70ef5b..d7f9e643ea 100644
--- a/src/include/stdbool.h
+++ b/src/include/stdbool.h
@@ -5,11 +5,8 @@
 
 #include <stdint.h>
 
-#ifdef __ROMCC__
-typedef uint8_t bool;
-#else
+
 typedef _Bool   bool;
-#endif
 #define true    1
 #define false   0
 
diff --git a/src/include/stddef.h b/src/include/stddef.h
index a2c9c50cd2..e3183096a0 100644
--- a/src/include/stddef.h
+++ b/src/include/stddef.h
@@ -47,12 +47,10 @@ typedef unsigned int wint_t;
 #define MAYBE_STATIC_BSS
 #endif
 
-#ifndef __ROMCC__
 /* Provide a pointer to address 0 that thwarts any "accessing this is
  * undefined behaviour and do whatever" trickery in compilers.
  * Use when you _really_ need to read32(zeroptr) (ie. read address 0).
  */
 extern char zeroptr[];
-#endif
 
 #endif /* STDDEF_H */
diff --git a/src/include/stdint.h b/src/include/stdint.h
index 67b0b0be08..b534addfe2 100644
--- a/src/include/stdint.h
+++ b/src/include/stdint.h
@@ -28,17 +28,14 @@ typedef unsigned short     uint16_t;
 typedef signed int         int32_t;
 typedef unsigned int       uint32_t;
 
-#ifndef __ROMCC__
 typedef signed long long   int64_t;
 typedef unsigned long long uint64_t;
-#endif
 
 /* Types for 'void *' pointers */
 typedef signed long        intptr_t;
 typedef unsigned long      uintptr_t;
 
 /* Ensure that the widths are all correct */
-#ifndef __ROMCC__
 _Static_assert(sizeof(int8_t) == 1, "Size of int8_t is incorrect");
 _Static_assert(sizeof(uint8_t) == 1, "Size of uint8_t is incorrect");
 
@@ -53,13 +50,10 @@ _Static_assert(sizeof(uint64_t) == 8, "Size of uint64_t is incorrect");
 
 _Static_assert(sizeof(intptr_t) == sizeof(void *), "Size of intptr_t is incorrect");
 _Static_assert(sizeof(uintptr_t) == sizeof(void *), "Size of uintptr_t is incorrect");
-#endif
 
 /* Maximum width integer types */
-#ifndef __ROMCC__
 typedef int64_t  intmax_t;
 typedef uint64_t uintmax_t;
-#endif
 
 /* Convenient typedefs */
 typedef int8_t   s8;
@@ -71,10 +65,8 @@ typedef uint16_t u16;
 typedef int32_t  s32;
 typedef uint32_t u32;
 
-#ifndef __ROMCC__
 typedef int64_t  s64;
 typedef uint64_t u64;
-#endif
 
 /* Limits of integer types */
 #define INT8_MIN   ((int8_t)0x80)
@@ -89,16 +81,12 @@ typedef uint64_t u64;
 #define INT32_MAX  ((int32_t)0x7FFFFFFF)
 #define UINT32_MAX ((uint32_t)0xFFFFFFFF)
 
-#ifndef __ROMCC__
 #define INT64_MIN  ((int64_t)0x8000000000000000)
 #define INT64_MAX  ((int64_t)0x7FFFFFFFFFFFFFFF)
 #define UINT64_MAX ((uint64_t)0xFFFFFFFFFFFFFFFF)
-#endif
 
-#ifndef __ROMCC__
 #define INTMAX_MIN  INT64_MIN
 #define INTMAX_MAX  INT64_MAX
 #define UINTMAX_MAX UINT64_MAX
-#endif
 
 #endif /* STDINT_H */
diff --git a/src/include/string.h b/src/include/string.h
index d3f09ff102..bcfc111431 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -4,9 +4,7 @@
 #include <stddef.h>
 #include <stdlib.h>
 
-#if !defined(__ROMCC__)
 #include <console/vtxprintf.h>
-#endif
 
 /* Stringify a token */
 #ifndef STRINGIFY
@@ -19,10 +17,8 @@ void *memmove(void *dest, const void *src, size_t n);
 void *memset(void *s, int c, size_t n);
 int memcmp(const void *s1, const void *s2, size_t n);
 void *memchr(const void *s, int c, size_t n);
-#if !defined(__ROMCC__)
 int snprintf(char *buf, size_t size, const char *fmt, ...);
 int vsnprintf(char *buf, size_t size, const char *fmt, va_list args);
-#endif
 char *strdup(const char *s);
 char *strconcat(const char *s1, const char *s2);
 size_t strnlen(const char *src, size_t max);
diff --git a/src/include/swab.h b/src/include/swab.h
index 57fe5a2e53..6a33b3969f 100644
--- a/src/include/swab.h
+++ b/src/include/swab.h
@@ -21,7 +21,7 @@
 
 #include <stdint.h>
 
-#if defined(__ROMCC__) || ENV_ARMV4
+#if ENV_ARMV4
 #define swab16(x) \
 	((unsigned short)( \
 		(((unsigned short)(x) & (unsigned short)0x00ffU) << 8) | \
@@ -44,10 +44,10 @@
 		(((uint64_t)(x) & (uint64_t)0x0000ff0000000000ULL) >> 24) | \
 		(((uint64_t)(x) & (uint64_t)0x00ff000000000000ULL) >> 40) | \
 		(((uint64_t)(x) & (uint64_t)0xff00000000000000ULL) >> 56)))
-#else	/* __ROMCC__ || ENV_ARMV4 */
+#else	/* ENV_ARMV4 */
 #define swab16(x) ((uint16_t)__builtin_bswap16(x))
 #define swab32(x) ((uint32_t)__builtin_bswap32(x))
 #define swab64(x) ((uint64_t)__builtin_bswap64(x))
-#endif	/* !(__ROMCC__ || ENV_ARMV4) */
+#endif	/* !ENV_ARMV4 */
 
 #endif /* _SWAB_H */