summaryrefslogtreecommitdiff
path: root/src/include/uart.h
diff options
context:
space:
mode:
authorDavid Hendricks <dhendrix@chromium.org>2013-04-08 20:01:18 -0700
committerRonald G. Minnich <rminnich@gmail.com>2013-04-10 00:04:57 +0200
commit086b369dfc6421c698cd5a386e75fde68cb838dc (patch)
treeb3378f616868263db406e88dab109381e0e950e7 /src/include/uart.h
parentb959fbb87adb274b442bc6ab812e5a2ce92ca220 (diff)
armv7: replace read/write macros with inlines
This enables type checking for safety as to help prevent errors like http://review.coreboot.org/#/c/3038/ . Now compilation fails if the wrong type is passed into readb/readw/readl/writeb/writew/writel or other macros in io.h. This also deprecates readw/writew. The previous definition was 16-bits which is incorrect since wordsize on ARMv7 is 32-bits and there was only 1 instance of writew (#if 0'd anyway). Going forward we should always use read{8,16,32} and write{8,16,32} where N specifies the exact length rather than relying on ambiguous definition of wordsize. Since many macros relied on __raw_*, which were basically the same (minus data memory barrier instructions), this patch also gets rid of __raw_*. There were parts of the code which ended up using these macros consecutively, for example: setbits_le32(&regs->ch_cfg, SPI_CH_RST); clrbits_le32(&regs->ch_cfg, SPI_CH_RST); In such cases the safe versions of readl() and writel() should be used anyway. Note: This also fixes two dubious casts as to avoid breaking compilation. Change-Id: I8850933f68ea3a9b615d00ebd422f7c242268f1c Signed-off-by: David Hendricks <dhendrix@chromium.org> Reviewed-on: http://review.coreboot.org/3045 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/include/uart.h')
0 files changed, 0 insertions, 0 deletions