summaryrefslogtreecommitdiff
path: root/src/include/device/device.h
diff options
context:
space:
mode:
authorHannah Williams <hannah.williams@intel.com>2018-05-27 09:58:25 -0700
committerFurquan Shaikh <furquan@google.com>2018-05-30 01:10:44 +0000
commitb81362a82e40fac5c6debd8e0034feacb00d5e0a (patch)
tree841dde898fa692343c6e74eb783fc5d1a5b2b9ee /src/include/device/device.h
parent5474eb15ef4cdf6c4f9df9d679d4b92354c178b8 (diff)
libpayload-x86: i8042: fix i8042_data_ready_ps2 and i8042_data_ready_aux
keyboard_disconnect was called without keyboard_init being called and in this case keyboard_havechar returns true because i8042_data_ready_ps2 is dereferencing uninitialized variable ps2_fifo from within fifo_is_empty causing keyboard_disconnect to be stuck in this while loop. while (keyboard_havechar()) keyboard_getchar(); BUG=b:80299098 TEST=Check if the normal mode path in depthcharge is not causing a hang Change-Id: I944b4836005c887a2715717dff2df1b5a220818e Signed-off-by: Hannah Williams <hannah.williams@intel.com> Reviewed-on: https://review.coreboot.org/26590 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/include/device/device.h')
0 files changed, 0 insertions, 0 deletions