diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2022-05-19 11:31:10 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-15 14:47:52 +0000 |
| commit | 56776a1ab39333c791903e0a7e79e8fb51d3162d (patch) | |
| tree | ffce5f6c84b0643cf6eaf0b288d2566d30796064 /src/include/cpu | |
| parent | 576861994ea5011c3a836a826b8189ef79c366cb (diff) | |
soc/amd: Do SMM relocation via MSR
AMD CPUs have a convenient MSR that allows to set the SMBASE in the save
state without ever entering SMM (e.g. at the default 0x30000 address).
This has been a feature in all AMD CPUs since at least AMD K8. This
allows to do relocation in parallel in ramstage and without setting up a
relocation handler, which likely results in a speedup. The more cores
the higher the speedup as relocation was happening sequentially. On a 4
core AMD picasso system this results in 33ms boot speedup.
TESTED on google/vilboz (Picasso) with CONFIG_SMI_DEBUG: verify that SMM
is correctly relocated with the BSP correctly entering the smihandler.
Change-Id: I9729fb94ed5c18cfd57b8098c838c08a04490e4b
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64872
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/include/cpu')
| -rw-r--r-- | src/include/cpu/x86/mp.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/include/cpu/x86/mp.h b/src/include/cpu/x86/mp.h index 8ee7d02431..343bd9c4fa 100644 --- a/src/include/cpu/x86/mp.h +++ b/src/include/cpu/x86/mp.h @@ -57,6 +57,9 @@ struct mp_ops { /* * Optional function to use to trigger SMM to perform relocation. If * not provided, smm_initiate_relocation() is used. + * This function is called on each CPU. + * On platforms that select CONFIG(X86_SMM_SKIP_RELOCATION_HANDLER) to + * not relocate in SMM, this function can be used to relocate CPUs. */ void (*per_cpu_smm_trigger)(void); /* @@ -66,6 +69,7 @@ struct mp_ops { * running the relocation handler, current SMBASE of relocation handler, * and the pre-calculated staggered CPU SMBASE address of the permanent * SMM handler. + * This function is only called with !CONFIG(X86_SMM_SKIP_RELOCATION_HANDLER) set. */ void (*relocation_handler)(int cpu, uintptr_t curr_smbase, uintptr_t staggered_smbase); |