diff options
| author | Karthikeyan Ramasubramanian <kramasub@chromium.org> | 2018-09-17 16:19:34 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-09-20 17:15:26 +0000 |
| commit | c80ff8437d61f0867eccc520cc68d19fe181af14 (patch) | |
| tree | fd94a2103e48b08c5df10421952a945bc7d68a9e /src/include/boardid.h | |
| parent | 2beadeec3512d6087ae5057da681e50883d04acf (diff) | |
ec/google/chromeec: Update google_chromeec_get_board_version prototype
The helper function to get the board version from EC returns 0 on
failure. But 0 is also a valid board version. Update the helper function
to return -1 on failure and update the use-cases.
BUG=b:114001972,b:114677884,b:114677887
Change-Id: I93e8dbce2ff26e76504b132055985f53cbf07d31
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Tested-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/28576
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jett Rink <jettrink@google.com>
Diffstat (limited to 'src/include/boardid.h')
| -rw-r--r-- | src/include/boardid.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/include/boardid.h b/src/include/boardid.h index e1bce0388a..a959b85367 100644 --- a/src/include/boardid.h +++ b/src/include/boardid.h @@ -20,6 +20,15 @@ #define UNDEFINED_STRAPPING_ID (~0) +#define BOARD_ID_UNKNOWN ~((uint32_t)0) /* unsigned equivalent to -1 */ +#define BOARD_ID_INIT ~((uint32_t)1) /* unsigned equivalent to -2 */ +/** + * board_id() - Get the board version + * + * Return: board version on success, BOARD_ID_UNKNOWN on failure/error. + * + * This function is used to get the mainboard version. + */ uint32_t board_id(void); /* differentiates revisions */ uint32_t ram_code(void); /* identifies installed DRAM modules */ uint32_t sku_id(void); /* differentiates other optional components */ |