diff options
author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-09-24 22:03:55 +0300 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2017-09-28 08:10:49 +0000 |
commit | d2fa33733325eb4ec4a3a5d8a658602a01cbf8d9 (patch) | |
tree | 117f331090bfc59fae367fbdd8e683ef085fbaf7 /src/include/base3.h | |
parent | 46300aa2ce91d3190602d88f16e553a040c842ef (diff) |
amd/stoneyridge: Drop FieldAcccessors
It was either SAGE or AMD AES who implemented these for
binaryPI, and it is not part of the documented AGESA API.
My conclusions of these are:
AmdGetValue() returns values from build-time configuration,
these may not reflect the actual run-time configuration as
there are OEM customization hooks to implement overrides.
AmdSetValue() in __PRE_RAM__ will fail, as configuration
data is const. Also AmdSetValue() in ramstage may fail, if
said configuration data has already been evaluated.
Semamtics of these calls are unusable unless one also has
access to PI source to make exact decision on when they
can be called. Remove these now that stoneyridge does not
actually require them.
Change-Id: I3379a75ce3b9448c17ef00eb16d3193c296626cd
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/21666
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/include/base3.h')
0 files changed, 0 insertions, 0 deletions