summaryrefslogtreecommitdiff
path: root/src/ec
diff options
context:
space:
mode:
authorAlexis Savery <asavery@chromium.org>2023-08-22 20:15:27 +0000
committerMatt DeVillier <matt.devillier@amd.corp-partner.google.com>2023-09-06 13:17:11 +0000
commit0d3745b67c9e457ad1401f3f1c322c1161231df3 (patch)
tree58c90acbc3fb7f7ad74d0ef324f053c7ffe7e133 /src/ec
parent184329c77a7750d86cfe1d848000dae0e72a3889 (diff)
google/puff: remove workaround that toggled the #ISOLATE pin
A workaround was added for puff to assert/deassert the #ISOLATE pin during suspend/resume to resolve the situation where the realtek ethernet device cannot enter L1.2 mode when its ASPM is disabled. The realtek driver has since been fixed and ASPM of realtek devices have been enabled on kernel 5.10 and 5.15 and this original workaround is now causing suspend/resume errors on kernel 5.15: r8169 0000:01:00.0: Unable to change power state from D3cold to D0, device inaccessible Puff devices were originally shipped with kernel 4.19, and applying this change to the firmware on a device running 4.19 causes suspend/resume failures, basically reversing the problem. We are upreving the puff kernel to 5.15 so we need this patch, but since it is incompatible with 4.19 we will have to take that into consideration when pushing new firmware and potentially will need to backport the necessary fixes to 4.19. BUG=b:268859220 TEST=suspend_stress_test -c 500 on wyvern Change-Id: I5eead2d70cd9528b3ca3fadd11f98c0330601324 Signed-off-by: Alexis Savery <asavery@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77378 Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sam McNally <sammc@google.com>
Diffstat (limited to 'src/ec')
0 files changed, 0 insertions, 0 deletions