summaryrefslogtreecommitdiff
path: root/src/ec
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2020-04-24 21:59:21 -0700
committerFurquan Shaikh <furquan@google.com>2020-04-28 19:50:26 +0000
commit7536a398e978aa8ddb0e5f2ae12bae73a708b68f (patch)
treeea6a86f305a7be6524b3470946f0f0726b055ade /src/ec
parentec3dafd97ccdc4cd4b08476724f3f53a47fbdb7a (diff)
device: Constify struct device * parameter to acpi_fill_ssdt()
.acpi_fill_ssdt() does not need to modify the device structure. This change makes the struct device * parameter to acpi_fill_ssdt() as const. Change-Id: I110f4c67c3b6671c9ac0a82e02609902a8ee5d5c Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40710 Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec')
-rw-r--r--src/ec/google/chromeec/ec.h2
-rw-r--r--src/ec/google/chromeec/ec_acpi.c6
-rw-r--r--src/ec/google/wilco/chip.c2
-rw-r--r--src/ec/lenovo/h8/h8.h2
-rw-r--r--src/ec/lenovo/h8/ssdt.c4
5 files changed, 8 insertions, 8 deletions
diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h
index 5f84722ac7..6014143b9d 100644
--- a/src/ec/google/chromeec/ec.h
+++ b/src/ec/google/chromeec/ec.h
@@ -344,7 +344,7 @@ int google_chromeec_get_keybd_config(struct ec_response_keybd_config *keybd);
*
* @param dev EC device
*/
-void google_chromeec_fill_ssdt_generator(struct device *dev);
+void google_chromeec_fill_ssdt_generator(const struct device *dev);
/**
* Returns the ACPI name for the EC device.
diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c
index 79e3f4bfa1..2331c7a492 100644
--- a/src/ec/google/chromeec/ec_acpi.c
+++ b/src/ec/google/chromeec/ec_acpi.c
@@ -187,7 +187,7 @@ static void add_usb_port_references(struct acpi_dp *dsd, int port_number)
}
}
-static void fill_ssdt_typec_device(struct device *dev)
+static void fill_ssdt_typec_device(const struct device *dev)
{
struct usb_pd_port_caps port_caps;
char con_name[] = "CONx";
@@ -249,7 +249,7 @@ static const enum ps2_action_key ps2_enum_val[] = {
[TK_PREV_TRACK] = PS2_KEY_PREV_TRACK,
};
-static void fill_ssdt_ps2_keyboard(struct device *dev)
+static void fill_ssdt_ps2_keyboard(const struct device *dev)
{
uint8_t i;
struct ec_response_keybd_config keybd = {};
@@ -273,7 +273,7 @@ static void fill_ssdt_ps2_keyboard(struct device *dev)
!!(keybd.capabilities & KEYBD_CAP_SCRNLOCK_KEY));
}
-void google_chromeec_fill_ssdt_generator(struct device *dev)
+void google_chromeec_fill_ssdt_generator(const struct device *dev)
{
if (!dev->enabled)
return;
diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c
index 7de4e0235e..0d0f987da3 100644
--- a/src/ec/google/wilco/chip.c
+++ b/src/ec/google/wilco/chip.c
@@ -179,7 +179,7 @@ static void wilco_ec_read_resources(struct device *dev)
wilco_ec_resource(dev, 2, CONFIG_EC_BASE_PACKET, 16);
}
-static void wilco_ec_fill_ssdt_generator(struct device *dev)
+static void wilco_ec_fill_ssdt_generator(const struct device *dev)
{
struct opregion opreg;
void *region_ptr;
diff --git a/src/ec/lenovo/h8/h8.h b/src/ec/lenovo/h8/h8.h
index 8999cc377a..5b2ae1ead9 100644
--- a/src/ec/lenovo/h8/h8.h
+++ b/src/ec/lenovo/h8/h8.h
@@ -35,7 +35,7 @@ void h8_wwan_enable(int on);
bool h8_wwan_nv_enable(void);
bool h8_has_wwan(const struct device *dev);
-void h8_ssdt_generator(struct device *dev);
+void h8_ssdt_generator(const struct device *dev);
/* EC registers */
#define H8_CONFIG0 0x00
diff --git a/src/ec/lenovo/h8/ssdt.c b/src/ec/lenovo/h8/ssdt.c
index 6b821a40f2..56e305a787 100644
--- a/src/ec/lenovo/h8/ssdt.c
+++ b/src/ec/lenovo/h8/ssdt.c
@@ -8,7 +8,7 @@
#include "h8.h"
#include "chip.h"
-static char *h8_dsdt_scope(struct device *dev, const char *scope)
+static char *h8_dsdt_scope(const struct device *dev, const char *scope)
{
static char buf[DEVICE_PATH_MAX] = {};
const char *path = acpi_device_path(dev);
@@ -22,7 +22,7 @@ static char *h8_dsdt_scope(struct device *dev, const char *scope)
/*
* Generates EC SSDT.
*/
-void h8_ssdt_generator(struct device *dev)
+void h8_ssdt_generator(const struct device *dev)
{
struct ec_lenovo_h8_config *conf = dev->chip_info;