diff options
| author | Sean Rhodes <sean@starlabs.systems> | 2023-02-16 08:21:15 +0000 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-09 21:38:26 +0000 |
| commit | 2285b72d0684f958ab372948d17f2da89db456c7 (patch) | |
| tree | 0c2f78ac00e6ee3846f0b3093c9d3389fafcd6ca /src/ec/starlabs/merlin/ite.c | |
| parent | 132fb3cc52884fa7634d7a9f6406eab3b4ea58d0 (diff) | |
Revert "ec/starlabs/merlin: Add support for enabling the mirror flag"
This reverts commit b42ca4d0b2fafe7214396d30a1a833ac33cf85bc.
Reason for revert: The mirror flag "0x01" is mirror once, which
relies on the EC remembering that it's been mirrored. However, the
EC forgets this if it's been without power for 20 minutes or so.
Even if power is connected then, it'll instantly try to mirror and
it can't charge whilst doing it. It can either result in
incomplete EC firmware, or a loop where it's constantly trying to
mirror.
Change-Id: I79da9143cc63459e7e29431eff2cb14200424b37
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72678
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/ec/starlabs/merlin/ite.c')
| -rw-r--r-- | src/ec/starlabs/merlin/ite.c | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c index d2d7c454d3..357c67cda5 100644 --- a/src/ec/starlabs/merlin/ite.c +++ b/src/ec/starlabs/merlin/ite.c @@ -70,7 +70,6 @@ static void merlin_init(struct device *dev) * trackpad_state * kbl_brightness * kbl_state - * mirror_flag */ /* @@ -248,25 +247,6 @@ static void merlin_init(struct device *dev) 1, kbl_state, ARRAY_SIZE(kbl_state))); - - /* - * Mirror Flag - * - * Setting: mirror_flag - * - * Values: Off, On - * Default: On - */ - const uint8_t mirror_flag[] = { - MIRROR_DISABLED, - MIRROR_ENABLED - }; - if (CONFIG(EC_STARLABS_MIRROR_FLAG)) - ec_write(ECRAM_MIRROR_FLAG, - get_ec_value_from_option("mirror_flag", - 1, - mirror_flag, - ARRAY_SIZE(mirror_flag))); } static struct device_operations ops = { |