summaryrefslogtreecommitdiff
path: root/src/ec/roda/it8518
diff options
context:
space:
mode:
authorJoel Kitching <kitching@google.com>2018-07-19 07:36:38 +0800
committerPatrick Georgi <pgeorgi@google.com>2018-07-19 07:25:37 +0000
commita302e7f46b582a163758bc9d53f8801e7cdb2443 (patch)
tree91cded63521f84d32518993cad434920ed4109d9 /src/ec/roda/it8518
parent202e7d4f3c50bfac53d06eaf0b0b1247f4c95be8 (diff)
cbfstool/add-payload: initialize segment headers to 0
Some types of payload segment headers do not use all fields. If these unused fields are not initialized to 0, they can cause problems in other software which consumes payloads. For example, PAYLOAD_SEGMENT_ENTRY does not use the compression field. If it happens to be a non-existent compression type, the 'cbfstool extract' command fails. BUG=https://ticket.coreboot.org/issues/170 TEST=cbfstool tianocore.cbfs create -s 2097152 -m x86 cbfstool tianocore.cbfs add-payload -f UEFIPAYLOAD.fd -n payload -c lzma -v xxd tianocore.cbfs | head # visually inspect compression field for 0 Change-Id: I359ed117ab4154438bac7172aebf608f7a022552 Signed-off-by: kitching@google.com Reviewed-on: https://review.coreboot.org/27540 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/ec/roda/it8518')
0 files changed, 0 insertions, 0 deletions