summaryrefslogtreecommitdiff
path: root/src/ec/quanta/it8518
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2022-12-26 08:17:06 +0100
committerFelix Singer <felixsinger@posteo.net>2022-12-27 09:03:34 +0000
commitca4b587f95c0f1ed64e187511781abdfd4c7ebfb (patch)
treebc5c5a324c65b107fd6d992167168b0383a63503 /src/ec/quanta/it8518
parentb4767ce169b202af2a9091275e30881172810fc6 (diff)
{superio,ec}/acpi: Replace constant "One" with actual number
Change-Id: I5c77b6d1e1dc1134f62dcb3e93df01dc9c2f386c Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71520 Reviewed-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec/quanta/it8518')
-rw-r--r--src/ec/quanta/it8518/acpi/battery.asl14
-rw-r--r--src/ec/quanta/it8518/acpi/ec.asl6
2 files changed, 10 insertions, 10 deletions
diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl
index fbbae1fdf2..4f3834a599 100644
--- a/src/ec/quanta/it8518/acpi/battery.asl
+++ b/src/ec/quanta/it8518/acpi/battery.asl
@@ -44,12 +44,12 @@ Device (BATX)
})
// Workaround for full battery status, enabled by default
- Name (BFWK, One)
+ Name (BFWK, 1)
// Method to enable full battery workaround
Method (BFWE)
{
- BFWK = One
+ BFWK = 1
}
// Method to disable full battery workaround
@@ -97,7 +97,7 @@ Device (BATX)
//
// Information ID 1 -
//
- HIID = One
+ HIID = 1
WAEC ()
//
@@ -106,7 +106,7 @@ Device (BATX)
// ACPI spec : 0 - mWh : 1 - mAh
//
Local7 = SBCM
- PBIF[0] = Local7 ^ One
+ PBIF[0] = Local7 ^ 1
//
// Information ID 0 -
@@ -224,7 +224,7 @@ Device (BATX)
{
if (HB0S & 0x40)
{
- Local0 = One
+ Local0 = 1
}
Else
{
@@ -249,7 +249,7 @@ Device (BATX)
Else
{
// Always discharging when on battery power
- Local1 = One
+ Local1 = 1
}
// Flag if the battery level is critical
@@ -282,7 +282,7 @@ Device (BATX)
}
}
- Local6 = DerefOf (PBIF[0]) ^ One
+ Local6 = DerefOf (PBIF[0]) ^ 1
If (Local6)
{
diff --git a/src/ec/quanta/it8518/acpi/ec.asl b/src/ec/quanta/it8518/acpi/ec.asl
index b05b3c7ad0..b510b8ab1a 100644
--- a/src/ec/quanta/it8518/acpi/ec.asl
+++ b/src/ec/quanta/it8518/acpi/ec.asl
@@ -550,7 +550,7 @@ Device (EC0)
\LIDS = ~HPLD
// Enable OS control of fan speed
- // TODO FCOS = One
+ // TODO FCOS = 1
// Force a read of CPU temperature
// TODO Which temperature corresponds to the CPU?
@@ -593,7 +593,7 @@ Device (EC0)
// AC Power Connected
Method (_Q26, 0, NotSerialized)
{
- \PWRS = One
+ \PWRS = 1
Notify (AC, 0x80)
Notify (BATX, 0x80)
\PNOT ()
@@ -610,7 +610,7 @@ Device (EC0)
// LID Open
Method (_Q2A)
{
- \LIDS = One
+ \LIDS = 1
Notify (\_SB.LID0, 0x80)
}