summaryrefslogtreecommitdiff
path: root/src/ec/lenovo/h8
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-06-17 20:13:08 +1000
committerPatrick Georgi <patrick@georgi-clan.de>2014-06-25 11:34:05 +0200
commitb57fef9f3e2b3cb8d8c8c5a3552c94a28ff81d15 (patch)
treecbc071f1b5b0f1e9db6458ede866ba76072c86fa /src/ec/lenovo/h8
parent0ddb82671cae52571e92b7b22cf088939d887d50 (diff)
src/ec: Sanitize headers and comment #endif pairings
Comment #endif /* FOO */ pairings. Alphabetise headers and remove any #if CONFIG_ guards around them. Background rational: Remove guarding the inclusion of headers based on CONFIG_ options. This *potentially* could hide issues such as functions being swapped from under our feet, since different runtime behaviour could be declared with the same function same name and type-signature. Hence, depending on the header we happen to get may change runtime behaviour. Change-Id: Ic61bdfb64d99f0e2998c6451ae6686915b7bb3d4 Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/6059 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src/ec/lenovo/h8')
-rw-r--r--src/ec/lenovo/h8/chip.h3
-rw-r--r--src/ec/lenovo/h8/h8.c9
-rw-r--r--src/ec/lenovo/h8/h8.h3
3 files changed, 9 insertions, 6 deletions
diff --git a/src/ec/lenovo/h8/chip.h b/src/ec/lenovo/h8/chip.h
index 37998ee6f3..bac54ecac6 100644
--- a/src/ec/lenovo/h8/chip.h
+++ b/src/ec/lenovo/h8/chip.h
@@ -50,4 +50,5 @@ struct ec_lenovo_h8_config {
u8 has_keyboard_backlight;
u8 has_power_management_beeps;
};
-#endif
+
+#endif /* EC_LENOVO_H8EC_CHIP_H */
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 8fffd5a754..f5b1b77ec8 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -20,14 +20,15 @@
#include <arch/io.h>
#include <console/console.h>
#include <device/device.h>
-#include <ec/acpi/ec.h>
#include <device/pnp.h>
+#include <ec/acpi/ec.h>
+#include <kconfig.h>
#include <stdlib.h>
+#include <string.h>
+#include <pc80/mc146818rtc.h>
+
#include "h8.h"
#include "chip.h"
-#include <pc80/mc146818rtc.h>
-#include <string.h>
-#include <kconfig.h>
static void h8_bluetooth_enable(int on)
{
diff --git a/src/ec/lenovo/h8/h8.h b/src/ec/lenovo/h8/h8.h
index dda3f659ad..6b3d4dbef0 100644
--- a/src/ec/lenovo/h8/h8.h
+++ b/src/ec/lenovo/h8/h8.h
@@ -124,4 +124,5 @@ void h8_mainboard_init_dock (void);
#define H8_EVENT_FN_F5 0x64
#define H8_EVENT_FN_F6 0x65
-#endif
+
+#endif /* EC_LENOVO_H8_H */