diff options
author | Iru Cai <mytbk920423@gmail.com> | 2017-03-26 10:25:00 +0800 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2017-08-11 16:10:52 +0000 |
commit | 44d399c394f0cd5d38dffe551742badc100573d3 (patch) | |
tree | 23084902b39de3b72963bfc8bf8d24ebce979951 /src/ec/hp/kbc1126/ec.c | |
parent | ae1548621acae99b7f7ac4a722607af0a4a0c825 (diff) |
ec: add support for KBC1126 in HP laptops
- let the coreboot build system insert the two blobs to the coreboot image
- EC and Super I/O initialization
- ACPI support
Tested on 2760p, 8460p, 2570p, 8470p.
Issue:
Kernel gives the following error:
ACPI Error: No handler for Region [ECRM] (...) [EmbeddedControl]
ACPI Error: Region EmbeddedControl (ID=3) has no handler
TODO:
- consider moving the Super I/O initialization code to ramstage, or
reuse the existing sio/smsc/kbc1100 code (if so, how to add the
additional kbc1126 specific functions to sio/kbc1100)
- sort out the ACPI code which is mostly from the ACPI dump of vendor
firmware
- find out why the digitizer in hp/2760p doesn't work
- GRUB payload freezing on all HP Elitebooks may be related to EC
Change-Id: I6b16eb7e26303eda740f52d667dedb7cc04b4ef0
Signed-off-by: Iru Cai <mytbk920423@gmail.com>
Reviewed-on: https://review.coreboot.org/19072
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/ec/hp/kbc1126/ec.c')
-rw-r--r-- | src/ec/hp/kbc1126/ec.c | 140 |
1 files changed, 140 insertions, 0 deletions
diff --git a/src/ec/hp/kbc1126/ec.c b/src/ec/hp/kbc1126/ec.c new file mode 100644 index 0000000000..a3e6e9c69c --- /dev/null +++ b/src/ec/hp/kbc1126/ec.c @@ -0,0 +1,140 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2009 coresystems GmbH + * Copyright (C) 2017 Iru Cai + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/io.h> +#include <console/console.h> +#include <device/device.h> +#include <delay.h> + +#include "ec.h" +#include "chip.h" + +static u16 ec_data_port; +static u16 ec_cmd_port; + +#define KBD_IBF (1 << 1) /* 1: input buffer full (data ready for ec) */ +#define KBD_OBF (1 << 0) /* 1: output buffer full (data ready for host) */ + +static void ec_setports(u16 data, u16 cmd) +{ + ec_data_port = data; + ec_cmd_port = cmd; +} + +static int send_kbd_command(u8 command) +{ + int timeout; + + timeout = 0x7ff; + while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) { + udelay(10); + if ((timeout & 0xff) == 0) + printk(BIOS_SPEW, "."); + } + if (!timeout) { + printk(BIOS_DEBUG, "Timeout while sending command 0x%02x to EC!\n", + command); + return -1; + } + + outb(command, ec_cmd_port); + return 0; +} + +static int send_kbd_data(u8 data) +{ + int timeout; + + timeout = 0x7ff; + while ((inb(ec_cmd_port) & KBD_IBF) && --timeout) { /* wait for IBF = 0 */ + udelay(10); + if ((timeout & 0xff) == 0) + printk(BIOS_SPEW, "."); + } + if (!timeout) { + printk(BIOS_DEBUG, "Timeout while sending data 0x%02x to EC!\n", + data); + return -1; + } + + outb(data, ec_data_port); + return 0; +} + +/* + * kbc1126_thermalinit: initialize fan control + * The code is found in EcThermalInit of the vendor firmware. + */ +static int kbc1126_thermalinit(u8 cmd, u8 value) +{ + printk(BIOS_DEBUG, "KBC1126: initialize fan control."); + + if (send_kbd_command(cmd) < 0) + return -1; + + if (send_kbd_data(0x27) < 0) + return -1; + + if (send_kbd_data(0x01) < 0) + return -1; + + /* + * The following code is needed for fan control when AC is plugged in. + */ + + if (send_kbd_command(cmd) < 0) + return -1; + + if (send_kbd_data(0xd5) < 0) + return -1; + + if (send_kbd_data(value) < 0) + return -1; + + printk(BIOS_DEBUG, "KBC1126: fan control initialized.\n"); + return 0; +} + +/* + * kbc1126_kbdled: set CapsLock and NumLock LEDs + * This is used in MemoryErrorReport of the vendor firmware. + */ +static void kbc1126_kbdled(u8 cmd, u8 val) +{ + if (send_kbd_command(cmd) < 0) + return; + + if (send_kbd_data(0xf0) < 0) + return; + + if (send_kbd_data(val) < 0) + return; +} + +static void kbc1126_enable(struct device *dev) +{ + struct ec_hp_kbc1126_config *conf = dev->chip_info; + ec_setports(conf->ec_data_port, conf->ec_cmd_port); + kbc1126_kbdled(conf->ec_ctrl_reg, 0); + if (kbc1126_thermalinit(conf->ec_ctrl_reg, conf->ec_fan_ctrl_value) < 0) + printk(BIOS_DEBUG, "KBC1126: error when initializing fan control.\n"); +} + +struct chip_operations ec_hp_kbc1126_ops = { + CHIP_NAME("SMSC KBC1126 for HP laptops") + .enable_dev = kbc1126_enable +}; |