diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2023-11-07 11:00:21 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-11-08 11:23:16 +0000 |
| commit | 9eb0b19861652f20d5f9153785ab307e70222a36 (patch) | |
| tree | 2b608f344690d0a320efb2abf3bcce875bbdd420 /src/drivers | |
| parent | 0fd61e67a04b38d43be7d4b0402d0382a2da5013 (diff) | |
drivers/i2c/lenovo_serials: Use buildtime constants
The coreboot_version global variable just gets filled with the
COREBOOT_VERSION macro so there is no reason to use a runtime strconcat.
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: I3a2be7293d07ac591855ebd784bba350cdffa70f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78945
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/drivers')
| -rw-r--r-- | src/drivers/i2c/at24rf08c/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/drivers/i2c/at24rf08c/lenovo_serials.c | 8 |
2 files changed, 3 insertions, 6 deletions
diff --git a/src/drivers/i2c/at24rf08c/Makefile.inc b/src/drivers/i2c/at24rf08c/Makefile.inc index 4ac3f1d75f..4ef2bc595c 100644 --- a/src/drivers/i2c/at24rf08c/Makefile.inc +++ b/src/drivers/i2c/at24rf08c/Makefile.inc @@ -1,4 +1,5 @@ ## SPDX-License-Identifier: GPL-2.0-only ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += at24rf08c.c +$(call src-to-obj,ramstage,$(dir)/lenovo_serials.c) : $(obj)/build.h ramstage-$(CONFIG_DRIVER_LENOVO_SERIALS) += lenovo_serials.c diff --git a/src/drivers/i2c/at24rf08c/lenovo_serials.c b/src/drivers/i2c/at24rf08c/lenovo_serials.c index bc01969b5a..dd09dda7fe 100644 --- a/src/drivers/i2c/at24rf08c/lenovo_serials.c +++ b/src/drivers/i2c/at24rf08c/lenovo_serials.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <build.h> #include <types.h> #include <string.h> #include <device/device.h> @@ -183,16 +184,11 @@ const char *smbios_mainboard_version(void) const char *smbios_mainboard_bios_version(void) { - static char *s = NULL; - /* Satisfy thinkpad_acpi. */ if (strlen(CONFIG_LOCALVERSION)) return "CBET4000 " CONFIG_LOCALVERSION; - if (s != NULL) - return s; - s = strconcat("CBET4000 ", coreboot_version); - return s; + return "CBET4000 " COREBOOT_VERSION; } const char *smbios_mainboard_manufacturer(void) |