summaryrefslogtreecommitdiff
path: root/src/drivers
diff options
context:
space:
mode:
authorPaul Menzel <pmenzel@molgen.mpg.de>2019-05-22 19:19:15 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-05-27 08:15:42 +0000
commit7ae606f57f0b3d450ae748141b0e2367041b27d3 (patch)
treecb27517cc3621b685ac1236c6f7f6bfffcd3f1f6 /src/drivers
parent82882288c9732aae9ba4baf7ff2916a886499ba2 (diff)
libpayload: Reset PS/2 keyboard
Loading a libpayload based payload like coreinfo or FILO from SeaBIOS or GRUB pressing keys does not give the expected results. For example, pressing F1 gives the character 24 translated to scan code 6a. ESC for example 43 (111) in coreinfo loaded from SeaBIOS on QEMU Q35. The problem is not reproducible using the payload directly, that means without SeaBIOS or GRUB. The problem seems to be, that those have already initialized the PS/2 controller and AT keyboard. Comparing it with coreboot’s PS/2 keyboard code, the keyboard needs to be reset. That seems to fix the issue, when the keyboard was initialized before. TEST=Build coreboot for QEMU Q35 with SeaBIOS, and coreinfo as secondary payload. Run qemu-system-i386 -M q35 -L /dev/shm -bios build/coreboot.rom -serial stdio press 3 to select the coreinfo payload, and verify that the keys F1 and F2 are working. Same with coreinfo loaded from GRUB on the ASRock E350M1. Change-Id: I2732292ac316d4bc0029ecb5c95fa7d1e7d68947 Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32951 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/drivers')
0 files changed, 0 insertions, 0 deletions