diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-03-04 17:49:56 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-03-09 02:18:21 +0000 |
| commit | 69cc557cfb6eb2cbb5b137bc206cd759c1dba5f0 (patch) | |
| tree | ab51422700fa7f5257fb72cc72bf8330780f8e06 /src/drivers | |
| parent | 270b0b60acba4802b8a9272d2727ee576733ad47 (diff) | |
commonlib/bsd: Remove cb_err_t
cb_err_t was meant to be used in place of `enum cb_err` in all
situations, but the choice to use a typedef here seems to be
controversial. We should not be arbitrarily using two different
identifiers for the same thing across the codebase, so since there are
no use cases for serializing enum cb_err at the moment (which would be
the primary reason to typedef a fixed-width integer instead), remove
cb_err_t again for now.
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Iaec36210d129db26d51f0a105d3de070c03b686b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62600
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers')
| -rw-r--r-- | src/drivers/mipi/panel.c | 4 | ||||
| -rw-r--r-- | src/drivers/parade/ps8640/ps8640.c | 12 | ||||
| -rw-r--r-- | src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c | 16 |
3 files changed, 16 insertions, 16 deletions
diff --git a/src/drivers/mipi/panel.c b/src/drivers/mipi/panel.c index f1d87c32d1..9646ecaa86 100644 --- a/src/drivers/mipi/panel.c +++ b/src/drivers/mipi/panel.c @@ -4,7 +4,7 @@ #include <delay.h> #include <mipi/panel.h> -cb_err_t mipi_panel_parse_init_commands(const void *buf, mipi_cmd_func_t cmd_func) +enum cb_err mipi_panel_parse_init_commands(const void *buf, mipi_cmd_func_t cmd_func) { const struct panel_init_command *init = buf; enum mipi_dsi_transaction type; @@ -68,7 +68,7 @@ cb_err_t mipi_panel_parse_init_commands(const void *buf, mipi_cmd_func_t cmd_fun return CB_ERR; } - cb_err_t ret = cmd_func(type, init->data, len); + enum cb_err ret = cmd_func(type, init->data, len); if (ret != CB_SUCCESS) return ret; buf += len; diff --git a/src/drivers/parade/ps8640/ps8640.c b/src/drivers/parade/ps8640/ps8640.c index 587eae1d9c..ebb2f4805b 100644 --- a/src/drivers/parade/ps8640/ps8640.c +++ b/src/drivers/parade/ps8640/ps8640.c @@ -81,12 +81,12 @@ int ps8640_init(uint8_t bus, uint8_t chip) return 0; } -static cb_err_t ps8640_bridge_aux_request(uint8_t bus, - uint8_t chip, - unsigned int target_reg, - unsigned int total_size, - enum aux_request request, - uint8_t *data) +static enum cb_err ps8640_bridge_aux_request(uint8_t bus, + uint8_t chip, + unsigned int target_reg, + unsigned int total_size, + enum aux_request request, + uint8_t *data) { int i; uint32_t length; diff --git a/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c b/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c index 2130e33ccf..c9f4ba5a81 100644 --- a/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c +++ b/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c @@ -155,12 +155,12 @@ static const unsigned int sn65dsi86_bridge_dp_rate_lut[] = { 0, 1620, 2160, 2430, 2700, 3240, 4320, 5400 }; -static cb_err_t sn65dsi86_bridge_aux_request(uint8_t bus, - uint8_t chip, - unsigned int target_reg, - unsigned int total_size, - enum aux_request request, - uint8_t *data) +static enum cb_err sn65dsi86_bridge_aux_request(uint8_t bus, + uint8_t chip, + unsigned int target_reg, + unsigned int total_size, + enum aux_request request, + uint8_t *data) { int i; uint32_t length; @@ -217,9 +217,9 @@ static cb_err_t sn65dsi86_bridge_aux_request(uint8_t bus, return CB_SUCCESS; } -cb_err_t sn65dsi86_bridge_read_edid(uint8_t bus, uint8_t chip, struct edid *out) +enum cb_err sn65dsi86_bridge_read_edid(uint8_t bus, uint8_t chip, struct edid *out) { - cb_err_t err; + enum cb_err err; u8 edid[EDID_LENGTH * 2]; int edid_size = EDID_LENGTH; |