diff options
| author | Martin Roth <gaumless@gmail.com> | 2015-06-19 23:39:38 -0600 |
|---|---|---|
| committer | Martin Roth <gaumless@gmail.com> | 2015-06-27 02:47:39 +0200 |
| commit | 0458370bf7f579966d42c6eb7fa067715b44b393 (patch) | |
| tree | 1e0affcf4842a2aef9fa50fb43caa814e2873867 /src/drivers | |
| parent | 302a2ec7d1751bf1b40e13df36c9ee1d31497f85 (diff) | |
Kconfig: Remove unnecessary and incorrect MRC_CACHE symbols
Because of a misunderstanding of how Kconfig files are parsed, the
OVERRIDE_MRC_CACHE_LOC symbol was added to make sure that the value
was correctly set. This is not needed unless for some reason the
Kconfig parser is suddenly rewritten to parse everything differently.
At some point, the value in the FSP's Kconfig file was updated to
OVERRIDE_CACHE_CACHE_LOC, while the entries in the mainboard
Kconfig files were not updated. This resulted in the default values
not getting set correctly by default on the FSP Bay Trail boards.
This removes the whole bunch of incorrect and unnecessary symbols and
just sets the default for the MRC cache location directly.
Change-Id: I1cec758576866b7e0677272b8309bfde8d4a1ee4
Signed-off-by: Martin Roth <gaumless@gmail.com>
Reviewed-on: http://review.coreboot.org/10611
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/drivers')
| -rw-r--r-- | src/drivers/intel/fsp1_0/Kconfig | 12 | ||||
| -rw-r--r-- | src/drivers/intel/fsp1_1/Kconfig | 12 |
2 files changed, 0 insertions, 24 deletions
diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index d2e144f31c..020235aab8 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -82,20 +82,8 @@ config MRC_CACHE_SIZE should be a full sector of the flash ROM chip and nothing else should be included in CBFS in any sector that the fast boot cache data is in. -config OVERRIDE_CACHE_CACHE_LOC - bool - help - Selected by the platform to set a new default location for the - MRC/fast boot cache. - -config MRC_CACHE_LOC_OVERRIDE - hex - help - Sets the override CBFS location of the MRC/fast boot cache. - config MRC_CACHE_LOC hex "Fast Boot Data Cache location in CBFS" - default MRC_CACHE_LOC_OVERRIDE if OVERRIDE_CACHE_CACHE_LOC default 0xfff50000 depends on ENABLE_MRC_CACHE help diff --git a/src/drivers/intel/fsp1_1/Kconfig b/src/drivers/intel/fsp1_1/Kconfig index 3c50a8d475..33283db699 100644 --- a/src/drivers/intel/fsp1_1/Kconfig +++ b/src/drivers/intel/fsp1_1/Kconfig @@ -103,7 +103,6 @@ config MRC_CACHE_FILE config MRC_CACHE_LOC hex "Fast Boot Data Cache location in CBFS" - default MRC_CACHE_LOC_OVERRIDE if OVERRIDE_CACHE_CACHE_LOC default 0xfff50000 depends on ENABLE_MRC_CACHE help @@ -113,11 +112,6 @@ config MRC_CACHE_LOC and nothing else should be included in that sector, or IT WILL BE ERASED. -config MRC_CACHE_LOC_OVERRIDE - hex - help - Sets the override CBFS location of the MRC/fast boot cache. - config MRC_CACHE_SIZE hex "Fast Boot Data Cache Size" default 0x10000 @@ -130,12 +124,6 @@ config MRC_CACHE_SIZE should be a full sector of the flash ROM chip and nothing else should be included in CBFS in any sector that the fast boot cache data is in. -config OVERRIDE_CACHE_CACHE_LOC - bool - help - Selected by the platform to set a new default location for the - MRC/fast boot cache. - config VIRTUAL_ROM_SIZE hex "Virtual ROM Size" default ROM_SIZE |