summaryrefslogtreecommitdiff
path: root/src/drivers
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2020-08-07 15:28:51 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-08-17 06:26:29 +0000
commit83b6283e618954d215578e0debd2d8aefbb0d3c5 (patch)
treea84610a0a8766442b5766c3c8b7458951265a6ee /src/drivers
parent2a59db7573625148bea70f9cf633544f6c2e21ae (diff)
drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
Value stored to 'size' is never read. Also drop unused parameter. Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/41697 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/drivers')
-rw-r--r--src/drivers/intel/fsp2_0/hand_off_block.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index 44c91a2949..60ab7cb3ec 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -207,7 +207,7 @@ const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size)
return NULL;
}
-static void display_fsp_version_info_hob(const void *hob, size_t size)
+static void display_fsp_version_info_hob(const void *hob)
{
#if CONFIG(DISPLAY_FSP_VERSION_INFO)
const FIRMWARE_VERSION_INFO *fvi;
@@ -219,7 +219,6 @@ static void display_fsp_version_info_hob(const void *hob, size_t size)
fvi = (void *)&fvih[1];
str_ptr = (char *)((uintptr_t)fvi +
(fvih->Count * sizeof(FIRMWARE_VERSION_INFO)));
- size -= sizeof(SMBIOS_STRUCTURE);
for (index = 0; index < fvih->Count; index++) {
cnt = strlen(str_ptr);
@@ -279,7 +278,7 @@ void fsp_display_fvi_version_hob(void)
if (fsp_guid_compare(hob_uuid, uuid_fv_info)) {
size = hob->length - (HOB_HEADER_LEN + 16);
- display_fsp_version_info_hob(hob, size);
+ display_fsp_version_info_hob(hob);
}
}
}