diff options
| author | Julius Werner <jwerner@chromium.org> | 2022-01-21 17:06:20 -0800 |
|---|---|---|
| committer | Julius Werner <jwerner@chromium.org> | 2022-02-07 23:29:09 +0000 |
| commit | e9665959edeba6ae2d5364c4f7339704b6b6fd42 (patch) | |
| tree | e3cd9e0e6e91c9b6bd5c6f586a9abee1d654b5dd /src/drivers/wifi | |
| parent | 266041f0e62296737617cc2fcfa97f31e2b43aea (diff) | |
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Diffstat (limited to 'src/drivers/wifi')
| -rw-r--r-- | src/drivers/wifi/generic/acpi.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index f4ffa5e514..7c606f9099 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -212,7 +212,7 @@ static void sar_emit_wrds(const struct sar_profile *sar) * }) */ if (sar->revision > MAX_SAR_REVISION) { - printk(BIOS_ERR, "ERROR: Invalid SAR table revision: %d\n", sar->revision); + printk(BIOS_ERR, "Invalid SAR table revision: %d\n", sar->revision); return; } @@ -258,12 +258,12 @@ static void sar_emit_ewrd(const struct sar_profile *sar) * }) */ if (sar->revision > MAX_SAR_REVISION) { - printk(BIOS_ERR, "ERROR: Invalid SAR table revision: %d\n", sar->revision); + printk(BIOS_ERR, "Invalid SAR table revision: %d\n", sar->revision); return; } if (sar->dsar_set_count == 0) { - printk(BIOS_WARNING, "WARNING: DSAR set count is 0\n"); + printk(BIOS_WARNING, "DSAR set count is 0\n"); return; } @@ -341,7 +341,7 @@ static void sar_emit_wgds(struct geo_profile *wgds) * }) */ if (wgds->revision > MAX_GEO_OFFSET_REVISION) { - printk(BIOS_ERR, "ERROR: Invalid WGDS revision: %d\n", wgds->revision); + printk(BIOS_ERR, "Invalid WGDS revision: %d\n", wgds->revision); return; } @@ -475,7 +475,7 @@ static void emit_sar_acpi_structures(const struct device *dev) /* Retrieve the sar limits data */ if (get_wifi_sar_limits(&sar_limits) < 0) { - printk(BIOS_ERR, "ERROR: failed getting SAR limits!\n"); + printk(BIOS_ERR, "failed getting SAR limits!\n"); return; } |