summaryrefslogtreecommitdiff
path: root/src/drivers/wifi/generic/Makefile.inc
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2021-03-13 22:34:57 -0800
committerPatrick Georgi <pgeorgi@google.com>2021-03-17 07:55:40 +0000
commit31f6320afeedfe622b0af51360078be28d26e378 (patch)
tree7d21135f9bfcef69f429204a09233ad53b22109c /src/drivers/wifi/generic/Makefile.inc
parenteb876a583049ca7765ab7c19e40bbbacaf17aa8e (diff)
drivers/wifi, mb/google: Drop config `WIFI_SAR_CBFS`
Now that SAR support in VPD is deprecated in coreboot, there is no need for a separate Kconfig `WIFI_SAR_CBFS` as the SAR table is only supported as a CBFS file. This change drops the config `WIFI_SAR_CBFS` from drivers/wifi/generic/Kconfig and its selection in mb/google/.../Kconfig. wifi_sar_defaults.hex is added to CBFS only if CONFIG_WIFI_SAR_CBFS_FILEPATH is not empty because current mainboards do not provide a default SAR file in coreboot. Thus, CONFIG_WIFI_SAR_CBFS_FILEPATH is updated to have a default value of "". BUG=b:173465272 Cq-Depend: chromium:2757781 Change-Id: I0bb8f6e2511596e4503fe4d8c34439228ceaa3c7 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51484 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers/wifi/generic/Makefile.inc')
-rw-r--r--src/drivers/wifi/generic/Makefile.inc10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/drivers/wifi/generic/Makefile.inc b/src/drivers/wifi/generic/Makefile.inc
index c17844993d..5650d8ab6f 100644
--- a/src/drivers/wifi/generic/Makefile.inc
+++ b/src/drivers/wifi/generic/Makefile.inc
@@ -5,8 +5,14 @@ ramstage-y += generic.c
ramstage-$(CONFIG_GENERATE_SMBIOS_TABLES) += smbios.c
ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c
-cbfs-files-$(CONFIG_WIFI_SAR_CBFS) += wifi_sar_defaults.hex
-wifi_sar_defaults.hex-file := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH))
+CONFIG_WIFI_SAR_CBFS_FILEPATH := $(call strip_quotes,$(CONFIG_WIFI_SAR_CBFS_FILEPATH))
+
+ifneq ($(CONFIG_WIFI_SAR_CBFS_FILEPATH),)
+
+cbfs-files-$(CONFIG_USE_SAR) += wifi_sar_defaults.hex
+wifi_sar_defaults.hex-file := $(CONFIG_WIFI_SAR_CBFS_FILEPATH)
wifi_sar_defaults.hex-type := raw
endif
+
+endif