diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-07-24 15:54:31 +0300 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-12-02 23:35:58 +0000 |
| commit | 8c99c27df10f6c5a120e41ffb0948e357f5a2d20 (patch) | |
| tree | 710940c338b8b2a3ddebab60faf7856725ca37e2 /src/drivers/uart | |
| parent | 5e053af7a677d0c1f98e624057ba7409f8492596 (diff) | |
lib/trace: Remove TRACE support
Looks like the option is generally not compatible with
garbage collections.
Nothing gets inlined, for example is_smp_boot() no longer
evaluates to constant false and thus the symbols from
secondary.S would need to be present for the build to pass
even if we set SMP=n.
Also the addresses of relocatable ramstage are currently
not normalised on the logs, so util/genprof would be unable
dress those.
Change-Id: I0b6f310e15e6f4992cd054d288903fea8390e5cf
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/drivers/uart')
| -rw-r--r-- | src/drivers/uart/uart8250io.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index d0841de39c..aa8c969530 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <boot/coreboot_tables.h> #include <console/uart.h> -#include <trace.h> #include "uart8250reg.h" /* Should support 8250, 16450, 16550, 16550A type UARTs */ @@ -54,7 +53,6 @@ static unsigned char uart8250_rx_byte(unsigned int base_port) static void uart8250_init(unsigned int base_port, unsigned int divisor) { - DISABLE_TRACE; /* Disable interrupts */ outb(0x0, base_port + UART8250_IER); /* Enable FIFOs */ @@ -72,7 +70,6 @@ static void uart8250_init(unsigned int base_port, unsigned int divisor) /* Set to 3 for 8N1 */ outb(CONFIG_TTYS0_LCS, base_port + UART8250_LCR); - ENABLE_TRACE; } static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 }; |