summaryrefslogtreecommitdiff
path: root/src/drivers/uart/sifive.c
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-09-11 15:47:09 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-12 14:59:33 +0000
commite3a1247b15e756f01d9c25bc71fa2cf563de34a8 (patch)
treeb5b3757f41355f0e046968f4bdf3c06b51941914 /src/drivers/uart/sifive.c
parent8395165eee0ab487993e78de52a63dbc669f6684 (diff)
include/console/uart: make index parameter unsigned
The UART index is never negative, so make it unsigned and drop the checks for the index to be non-negative. Change-Id: I64bd60bd2a3b82552cb3ac6524792b9ac6c09a94 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45294 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/drivers/uart/sifive.c')
-rw-r--r--src/drivers/uart/sifive.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/drivers/uart/sifive.c b/src/drivers/uart/sifive.c
index 0c94c6aeaa..31181aa51f 100644
--- a/src/drivers/uart/sifive.c
+++ b/src/drivers/uart/sifive.c
@@ -45,7 +45,7 @@ static void sifive_uart_init(struct sifive_uart_registers *regs, int div)
write32(&regs->rxctrl, RXCTRL_RXEN|RXCTRL_RXCNT(0));
}
-void uart_init(int idx)
+void uart_init(unsigned int idx)
{
unsigned int div;
div = uart_baudrate_divisor(get_uart_baudrate(),
@@ -58,7 +58,7 @@ static bool uart_can_tx(struct sifive_uart_registers *regs)
return !(read32(&regs->txdata) & TXDATA_FULL);
}
-void uart_tx_byte(int idx, unsigned char data)
+void uart_tx_byte(unsigned int idx, unsigned char data)
{
struct sifive_uart_registers *regs = uart_platform_baseptr(idx);
@@ -68,7 +68,7 @@ void uart_tx_byte(int idx, unsigned char data)
write32(&regs->txdata, data);
}
-void uart_tx_flush(int idx)
+void uart_tx_flush(unsigned int idx)
{
struct sifive_uart_registers *regs = uart_platform_baseptr(idx);
uint32_t ip;
@@ -79,7 +79,7 @@ void uart_tx_flush(int idx)
} while (!(ip & IP_TXWM));
}
-unsigned char uart_rx_byte(int idx)
+unsigned char uart_rx_byte(unsigned int idx)
{
struct sifive_uart_registers *regs = uart_platform_baseptr(idx);
uint32_t rxdata;