diff options
author | Caveh Jalali <caveh@chromium.org> | 2020-09-10 01:25:29 -0700 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2020-09-16 07:14:40 +0000 |
commit | 8274c2926fbee8125a0cba4d38cd020b98c397c8 (patch) | |
tree | b048006c47f2bcbda2f4df3178f925eac6221b7d /src/drivers/lenovo/hybrid_graphics | |
parent | 0f651650f38c5166a934b3541f56f32bf4fd93b2 (diff) |
drivers/spi/tpm: Improve error checking
This adds error checking in paths that previously ignored TPM
communication errors. We hit this case occasionally during "Checking
cr50 for pending updates"; previously we would go down this path and
eventually time out using MAX_STATUS_TIMEOUT, which is 2 minutes.
Now, we detect the failure and return with an error indication instead
of timing out after a long time. The root cause of the communication
error is an open issue.
BUG=b:168090038
TEST=booted on volteer, observed error handling when
"Checking cr50 for pending updates" fails.
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: Ia8a1202000abce1857ee694b06b1478e6b045069
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45232
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jes Klinke <jbk@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/drivers/lenovo/hybrid_graphics')
0 files changed, 0 insertions, 0 deletions