summaryrefslogtreecommitdiff
path: root/src/drivers/ipmi
diff options
context:
space:
mode:
authorElyes Haouas <ehaouas@noos.fr>2022-11-18 15:05:39 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-11-22 13:40:56 +0000
commit1ef547eec7262f96770f1fe4d1c6ff44b624dbe2 (patch)
tree208ee987a82a1a5db011fccab7e6a9ed9ef8cdb4 /src/drivers/ipmi
parent385939f7cfeeb732c4a54f6069940c2a7de53579 (diff)
src/drivers: Remove unnecessary space after casts
Change-Id: I16689da893b5a0c3254364759d435281cb3e1caf Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69803 Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/drivers/ipmi')
-rw-r--r--src/drivers/ipmi/ipmi_fru.c4
-rw-r--r--src/drivers/ipmi/ipmi_ops.c18
-rw-r--r--src/drivers/ipmi/ocp/ipmi_ocp.c4
-rw-r--r--src/drivers/ipmi/ocp/ipmi_ocp_romstage.c8
-rw-r--r--src/drivers/ipmi/supermicro_oem.c8
5 files changed, 21 insertions, 21 deletions
diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c
index f16530705f..844eb8e8a3 100644
--- a/src/drivers/ipmi/ipmi_fru.c
+++ b/src/drivers/ipmi/ipmi_fru.c
@@ -36,8 +36,8 @@ static enum cb_err ipmi_read_fru(const int port, struct ipmi_read_fru_data_req *
while (retry_count <= MAX_FRU_BUSY_RETRY) {
ret = ipmi_message(port, IPMI_NETFN_STORAGE, 0x0,
- IPMI_READ_FRU_DATA, (const unsigned char *) req,
- sizeof(*req), (unsigned char *) &rsp, sizeof(rsp));
+ IPMI_READ_FRU_DATA, (const unsigned char *)req,
+ sizeof(*req), (unsigned char *)&rsp, sizeof(rsp));
if (rsp.resp.completion_code == 0x81) {
/* Device is busy */
if (retry_count == MAX_FRU_BUSY_RETRY) {
diff --git a/src/drivers/ipmi/ipmi_ops.c b/src/drivers/ipmi/ipmi_ops.c
index d9b3256eec..18547c5530 100644
--- a/src/drivers/ipmi/ipmi_ops.c
+++ b/src/drivers/ipmi/ipmi_ops.c
@@ -21,8 +21,8 @@ enum cb_err ipmi_init_and_start_bmc_wdt(const int port, uint16_t countdown,
req.initial_countdown_val = countdown;
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_SET_WDG_TIMER,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
printk(BIOS_ERR, "IPMI: %s set wdt command failed "
@@ -35,7 +35,7 @@ enum cb_err ipmi_init_and_start_bmc_wdt(const int port, uint16_t countdown,
/* Reset command to start timer */
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_RESET_WDG_TIMER, NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
printk(BIOS_ERR, "IPMI: %s reset wdt command failed "
@@ -59,7 +59,7 @@ enum cb_err ipmi_stop_bmc_wdt(const int port)
/* Get current timer first */
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_GET_WDG_TIMER, NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s get wdt command failed "
@@ -79,8 +79,8 @@ enum cb_err ipmi_stop_bmc_wdt(const int port)
req = rsp.data;
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_SET_WDG_TIMER,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &resp, sizeof(resp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&resp, sizeof(resp));
if (ret < sizeof(struct ipmi_rsp) || resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s set wdt command stop timer failed "
@@ -107,7 +107,7 @@ enum cb_err ipmi_get_system_guid(const int port, uint8_t *uuid)
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_GET_SYSTEM_GUID, NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n",
@@ -130,8 +130,8 @@ enum cb_err ipmi_add_sel(const int port, struct sel_event_record *sel)
}
ret = ipmi_message(port, IPMI_NETFN_STORAGE, 0x0,
- IPMI_ADD_SEL_ENTRY, (const unsigned char *) sel,
- 16, (unsigned char *) &rsp, sizeof(rsp));
+ IPMI_ADD_SEL_ENTRY, (const unsigned char *)sel,
+ 16, (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n",
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.c b/src/drivers/ipmi/ocp/ipmi_ocp.c
index 9f583be934..e75edca659 100644
--- a/src/drivers/ipmi/ocp/ipmi_ocp.c
+++ b/src/drivers/ipmi/ocp/ipmi_ocp.c
@@ -29,8 +29,8 @@ static enum cb_err ipmi_set_ppin(struct device *dev)
req.cpu1_hi = xeon_sp_ppin[1].hi;
}
ret = ipmi_message(dev->path.pnp.port, IPMI_NETFN_OEM, 0x0, IPMI_OEM_SET_PPIN,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n",
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c b/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
index 7b0b9ea036..8ef379eef2 100644
--- a/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
+++ b/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
@@ -11,7 +11,7 @@ enum cb_err ipmi_set_post_start(const int port)
struct ipmi_rsp rsp;
ret = ipmi_message(port, IPMI_NETFN_OEM, 0x0,
- IPMI_BMC_SET_POST_START, NULL, 0, (u8 *) &rsp,
+ IPMI_BMC_SET_POST_START, NULL, 0, (u8 *)&rsp,
sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
@@ -45,7 +45,7 @@ enum cb_err ipmi_set_cmos_clear(void)
ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0,
IPMI_OEM_GET_BIOS_BOOT_ORDER,
NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (read ret=%d resp=0x%x)\n",
@@ -58,8 +58,8 @@ enum cb_err ipmi_set_cmos_clear(void)
SET_CMOS_AND_VALID_BIT(req.boot_mode);
ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0,
IPMI_OEM_SET_BIOS_BOOT_ORDER,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (sent ret=%d resp=0x%x)\n",
diff --git a/src/drivers/ipmi/supermicro_oem.c b/src/drivers/ipmi/supermicro_oem.c
index 7af4e3b8a4..c63da5f020 100644
--- a/src/drivers/ipmi/supermicro_oem.c
+++ b/src/drivers/ipmi/supermicro_oem.c
@@ -36,8 +36,8 @@ static void set_coreboot_ver(const uint16_t kcs_port)
bios_ver.ver = IPMI_LUN0_AC_SET_BIOS_VER;
ret = ipmi_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING,
- (const unsigned char *) &bios_ver, sizeof(bios_ver),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&bios_ver, sizeof(bios_ver),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(rsp) || rsp.completion_code) {
printk(BIOS_ERR, "BMC_IPMI: %s command failed (ret=%d resp=0x%x)\n",
__func__, ret, rsp.completion_code);
@@ -55,8 +55,8 @@ static void set_coreboot_date(const uint16_t kcs_port)
bios_ver.ver = IPMI_LUN0_AC_SET_BIOS_DATE;
ret = ipmi_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING,
- (const unsigned char *) &bios_ver, sizeof(bios_ver),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&bios_ver, sizeof(bios_ver),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(rsp) || rsp.completion_code) {
printk(BIOS_ERR, "BMC_IPMI: %s command failed (ret=%d resp=0x%x)\n",
__func__, ret, rsp.completion_code);