aboutsummaryrefslogtreecommitdiff
path: root/src/drivers/intel
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2018-07-08 12:33:47 +0200
committerPatrick Georgi <pgeorgi@google.com>2018-07-09 09:27:34 +0000
commitb0b0c8c60a6072d1b0707f9b9b87650570b35ea3 (patch)
treefa3f70a9890aa2f45ee15d4c3c99f851c5a74df4 /src/drivers/intel
parent6c9737b1ac5b71f705350a960dee0e68b9afb440 (diff)
src/{device,drivers}: Use "foo *bar" instead of "foo* bar"
Change-Id: Ic1c9b1edd8d3206a68854107ddcbc5c51cb487c3 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/27404 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/drivers/intel')
-rw-r--r--src/drivers/intel/fsp1_0/fastboot_cache.c2
-rw-r--r--src/drivers/intel/fsp1_0/fsp_util.c13
-rw-r--r--src/drivers/intel/fsp1_0/fsp_util.h16
-rw-r--r--src/drivers/intel/fsp1_0/hob.c10
-rw-r--r--src/drivers/intel/gma/edid.c2
-rw-r--r--src/drivers/intel/i210/i210.c12
6 files changed, 28 insertions, 27 deletions
diff --git a/src/drivers/intel/fsp1_0/fastboot_cache.c b/src/drivers/intel/fsp1_0/fastboot_cache.c
index 906b356b90..76241c8f90 100644
--- a/src/drivers/intel/fsp1_0/fastboot_cache.c
+++ b/src/drivers/intel/fsp1_0/fastboot_cache.c
@@ -224,7 +224,7 @@ void update_mrc_cache(void *unused)
#endif /* !defined(__PRE_RAM__) */
-void * find_and_set_fastboot_cache(void)
+void *find_and_set_fastboot_cache(void)
{
struct mrc_data_container *mrc_cache = NULL;
if (((mrc_cache = find_current_mrc_cache()) == NULL) ||
diff --git a/src/drivers/intel/fsp1_0/fsp_util.c b/src/drivers/intel/fsp1_0/fsp_util.c
index 5a6321d220..c19c1a1186 100644
--- a/src/drivers/intel/fsp1_0/fsp_util.c
+++ b/src/drivers/intel/fsp1_0/fsp_util.c
@@ -75,7 +75,7 @@ void __attribute__((noreturn)) fsp_early_init (FSP_INFO_HEADER *fsp_ptr)
UPD_DATA_REGION fsp_upd_data;
#endif
- memset((void*)&FspRtBuffer, 0, sizeof(FSP_INIT_RT_BUFFER));
+ memset((void *)&FspRtBuffer, 0, sizeof(FSP_INIT_RT_BUFFER));
FspRtBuffer.Common.StackTop = (u32 *)CONFIG_RAMTOP;
FspInitParams.NvsBufferPtr = NULL;
@@ -100,7 +100,7 @@ void __attribute__((noreturn)) fsp_early_init (FSP_INFO_HEADER *fsp_ptr)
}
#endif /* __PRE_RAM__ */
-volatile u8 * find_fsp ()
+volatile u8 *find_fsp()
{
#ifdef __PRE_RAM__
@@ -175,7 +175,7 @@ volatile u8 * find_fsp ()
* @param hob_list_ptr pointer to the start of the hob list
* @return pointer to saved CAR MEM or NULL if not found.
*/
-void * find_saved_temp_mem(void *hob_list_ptr)
+void *find_saved_temp_mem(void *hob_list_ptr)
{
EFI_GUID temp_hob_guid = FSP_BOOTLOADER_TEMPORARY_MEMORY_HOB_GUID;
EFI_HOB_GUID_TYPE *saved_mem_hob =
@@ -194,7 +194,7 @@ void * find_saved_temp_mem(void *hob_list_ptr)
* @param hob_list_ptr pointer to the start of the hob list
* @return pointer to the start of the FSP reserved memory or NULL if not found.
*/
-void * find_fsp_reserved_mem(void *hob_list_ptr)
+void *find_fsp_reserved_mem(void *hob_list_ptr)
{
EFI_GUID fsp_reserved_guid = FSP_HOB_RESOURCE_OWNER_FSP_GUID;
EFI_HOB_RESOURCE_DESCRIPTOR *fsp_reserved_mem =
@@ -221,7 +221,8 @@ void print_fsp_info(void) {
}
if (FspHobListPtr == NULL) {
- FspHobListPtr = (void*)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));
+ FspHobListPtr = (void *)*((u32 *)
+ cbmem_find(CBMEM_ID_HOB_POINTER));
}
printk(BIOS_SPEW,"fsp_header_ptr: %p\n", fsp_header_ptr);
@@ -294,7 +295,7 @@ int save_mrc_data(void *hob_start)
static void find_fsp_hob_update_mrc(void *unused)
{
/* Set the global HOB list pointer */
- FspHobListPtr = (void*)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));
+ FspHobListPtr = (void *)*((u32 *) cbmem_find(CBMEM_ID_HOB_POINTER));
if (!FspHobListPtr){
printk(BIOS_ERR, "ERROR: Could not find FSP HOB pointer in CBFS!\n");
diff --git a/src/drivers/intel/fsp1_0/fsp_util.h b/src/drivers/intel/fsp1_0/fsp_util.h
index a3a7dd3119..594a25939f 100644
--- a/src/drivers/intel/fsp1_0/fsp_util.h
+++ b/src/drivers/intel/fsp1_0/fsp_util.h
@@ -22,10 +22,10 @@
#if IS_ENABLED(CONFIG_ENABLE_MRC_CACHE)
int save_mrc_data(void *hob_start);
-void * find_and_set_fastboot_cache(void);
+void *find_and_set_fastboot_cache(void);
#endif
-volatile u8 * find_fsp(void);
+volatile u8 *find_fsp(void);
void fsp_early_init(FSP_INFO_HEADER *fsp_info);
void FspNotify(u32 Phase);
void FspNotifyReturnPoint(EFI_STATUS Status, VOID *HobListPtr);
@@ -34,16 +34,16 @@ void print_fsp_info(void);
void chipset_fsp_early_init(FSP_INIT_PARAMS *FspInitParams,
FSP_INFO_HEADER *fsp_ptr);
void ChipsetFspReturnPoint(EFI_STATUS Status, VOID *HobListPtr);
-void * find_saved_temp_mem(void *hob_list_ptr);
-void * find_fsp_reserved_mem(void *hob_list_ptr);
+void *find_saved_temp_mem(void *hob_list_ptr);
+void *find_fsp_reserved_mem(void *hob_list_ptr);
/* functions in hob.c */
void print_hob_mem_attributes(void *Hobptr);
void print_hob_type_structure(u16 Hobtype, void *Hoblistptr);
void print_hob_resource_attributes(void *Hobptr);
void print_guid_type_attributes(void *Hobptr);
-const char * get_hob_type_string(void *Hobptr);
-void * find_hob_by_guid(void *Hoblistptr, EFI_GUID *guid1);
+const char *get_hob_type_string(void *Hobptr);
+void *find_hob_by_guid(void *Hoblistptr, EFI_GUID *guid1);
uint8_t guids_are_equal(EFI_GUID *guid1, EFI_GUID *guid2);
void printguid(EFI_GUID *guid);
@@ -90,10 +90,10 @@ void update_mrc_cache(void *unused);
#define FSP_SIG 0x48505346 /* 'FSPH' */
#define ERROR_NO_FV_SIG 1
-#define ERROR_NO_FFS_GUID 2
+#define ERROR_NO_FFS_GUID 2
#define ERROR_NO_INFO_HEADER 3
#define ERROR_IMAGEBASE_MISMATCH 4
-#define ERROR_INFO_HEAD_SIG_MISMATCH 5
+#define ERROR_INFO_HEAD_SIG_MISMATCH 5
#define ERROR_FSP_SIG_MISMATCH 6
#ifndef __PRE_RAM__
diff --git a/src/drivers/intel/fsp1_0/hob.c b/src/drivers/intel/fsp1_0/hob.c
index 1c6d0bba69..93348931c1 100644
--- a/src/drivers/intel/fsp1_0/hob.c
+++ b/src/drivers/intel/fsp1_0/hob.c
@@ -42,7 +42,7 @@ void print_hob_mem_attributes(void *Hobptr)
EFI_MEMORY_TYPE Hobmemtype = HobMemoryPtr->AllocDescriptor.MemoryType;
u64 Hobmemaddr = HobMemoryPtr->AllocDescriptor.MemoryBaseAddress;
u64 Hobmemlength = HobMemoryPtr->AllocDescriptor.MemoryLength;
- const char * Hobmemtypenames[15];
+ const char *Hobmemtypenames[15];
Hobmemtypenames[0] = "EfiReservedMemoryType";
Hobmemtypenames[1] = "EfiLoaderCode";
@@ -104,7 +104,7 @@ void print_hob_resource_attributes(void *Hobptr)
(unsigned long)Hobresaddr, (unsigned long)Hobreslength);
}
-const char * get_hob_type_string(void *Hobptr)
+const char *get_hob_type_string(void *Hobptr)
{
EFI_HOB_GENERIC_HEADER *HobHeaderPtr = (EFI_HOB_GENERIC_HEADER *)Hobptr;
u16 Hobtype = HobHeaderPtr->HobType;
@@ -215,7 +215,7 @@ void print_hob_type_structure(u16 Hobtype, void *Hoblistptr)
* @param guid the GUID of the HOB entry to find
* @return pointer to the start of the requested HOB or NULL if not found.
*/
-void * find_hob_by_guid(void *current_hob, EFI_GUID *guid)
+void *find_hob_by_guid(void *current_hob, EFI_GUID *guid)
{
do {
switch (((EFI_HOB_GENERIC_HEADER *)current_hob)->HobType) {
@@ -255,8 +255,8 @@ void * find_hob_by_guid(void *current_hob, EFI_GUID *guid)
*/
uint8_t guids_are_equal(EFI_GUID *guid1, EFI_GUID *guid2)
{
- uint64_t* guid_1 = (void *) guid1;
- uint64_t* guid_2 = (void *) guid2;
+ uint64_t *guid_1 = (void *) guid1;
+ uint64_t *guid_2 = (void *) guid2;
if ((*(guid_1) != *(guid_2)) || (*(guid_1 + 1) != *(guid_2 + 1)))
return 0;
diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c
index 316e869544..13b301fde9 100644
--- a/src/drivers/intel/gma/edid.c
+++ b/src/drivers/intel/gma/edid.c
@@ -39,7 +39,7 @@ static void wait_rdy(u8 *mmio)
}
}
-static void intel_gmbus_stop_bus(u8 * mmio, u8 bus)
+static void intel_gmbus_stop_bus(u8 *mmio, u8 bus)
{
wait_rdy(mmio);
write32(GMBUS0_ADDR, bus);
diff --git a/src/drivers/intel/i210/i210.c b/src/drivers/intel/i210/i210.c
index 2eae6a92bd..32d27f7912 100644
--- a/src/drivers/intel/i210/i210.c
+++ b/src/drivers/intel/i210/i210.c
@@ -26,7 +26,7 @@
/* This is a private function to wait for a bit mask in a given register */
/* To avoid endless loops, a time-out is implemented here. */
-static int wait_done(uint32_t* reg, uint32_t mask)
+static int wait_done(uint32_t *reg, uint32_t mask)
{
uint32_t timeout = I210_POLL_TIMEOUT_US;
@@ -58,7 +58,7 @@ static uint32_t read_flash(struct device *dev, uint32_t address,
bar = pci_read_config32(dev, PCI_BASE_ADDRESS_0);
if ((!bar) || ((address + count) > 0x40))
return I210_INVALID_PARAM;
- eeprd = (uint32_t*)(bar + I210_REG_EEREAD);
+ eeprd = (uint32_t *)(bar + I210_REG_EEREAD);
/* Prior to start ensure flash interface is ready by checking DONE-bit */
if (wait_done(eeprd, I210_DONE))
return I210_NOT_READY;
@@ -122,8 +122,8 @@ static uint32_t write_flash(struct device *dev, uint32_t address,
bar = pci_read_config32(dev, 0x10);
if ((!bar) || ((address + count) > 0x40))
return I210_INVALID_PARAM;
- eepwr = (uint32_t*)(bar + I210_REG_EEWRITE);
- eectrl = (uint32_t*)(bar + I210_REG_EECTRL);
+ eepwr = (uint32_t *)(bar + I210_REG_EEWRITE);
+ eectrl = (uint32_t *)(bar + I210_REG_EECTRL);
/* Prior to start ensure flash interface is ready by checking DONE-bit */
if (wait_done(eepwr, I210_DONE))
return I210_NOT_READY;
@@ -166,7 +166,7 @@ static uint32_t read_mac_adr(struct device *dev, uint8_t *mac_adr)
return I210_READ_ERROR;
/* Copy the address into destination. This is done because of possible */
/* not matching alignment for destination to uint16_t boundary. */
- memcpy(mac_adr, (uint8_t*)adr, 6);
+ memcpy(mac_adr, (uint8_t *)adr, 6);
return I210_SUCCESS;
}
@@ -181,7 +181,7 @@ static uint32_t write_mac_adr(struct device *dev, uint8_t *mac_adr)
if (!dev || !mac_adr)
return I210_INVALID_PARAM;
/* Copy desired address into a local buffer to avoid alignment issues */
- memcpy((uint8_t*)adr, mac_adr, 6);
+ memcpy((uint8_t *)adr, mac_adr, 6);
return write_flash(dev, 0, 3, adr);
}