diff options
author | Jeremy Compostella <jeremy.compostella@intel.com> | 2023-01-19 18:58:30 -0700 |
---|---|---|
committer | Nick Vaccaro <nvaccaro@google.com> | 2023-01-26 16:53:35 +0000 |
commit | b628beca3428731b6ea43218caa27bdaf8eb651d (patch) | |
tree | 139228ca748e7e11a6301cd0639c8b12446d46be /src/drivers/intel/gma/libgfxinit.h | |
parent | e02e918eba3f0803d354faf3d28072ee2307f7e5 (diff) |
drivers/intel/gma: Use libgfxinit Update_Output to turn off graphics
We were using the libgfxinit `Initialize' function with the
`Clean_State' parameter because the more appropriate `Update_Output'
function was not performing all the necessary clean up operations for
the PEIM driver to be successful when libgfxinit was used in romstage.
Thanks to a lot of experiments and some log analysis efforts, we were
able to identify the missing operation and fix the `Update_Output'
function (cf. https://review.coreboot.org/c/libgfxinit/+/72123).
The `initialized' global variable is now unnecessary as we track the
initialization in the Ada code instead.
Since the `Update_Output' function does not return any value, this
patch modifies the `gma_gfxstop' prototype accordingly. This does not
have any impact as the return value was not used anyway.
BUG=b:264526798
BRANCH=firmware-brya-14505.B
TEST=Developer screen is visible
Change-Id: I53d6fadf65dc09bd984de96edb4c1f15b64aeed0
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72125
Reviewed-by: Tarun Tuli <taruntuli@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Diffstat (limited to 'src/drivers/intel/gma/libgfxinit.h')
-rw-r--r-- | src/drivers/intel/gma/libgfxinit.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/intel/gma/libgfxinit.h b/src/drivers/intel/gma/libgfxinit.h index 3270b91752..24079c31ff 100644 --- a/src/drivers/intel/gma/libgfxinit.h +++ b/src/drivers/intel/gma/libgfxinit.h @@ -17,7 +17,7 @@ enum { }; void gma_gfxinit(int *lightup_ok); -void gma_gfxstop(int *stop_ok); +void gma_gfxstop(void); int gma_read_edid(unsigned char edid[], int port); #endif |