diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2016-08-01 15:47:42 -0700 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2016-08-03 06:16:16 +0200 |
| commit | 52d0c682bf3bb39584a1edd6e7326a6f4c1267f7 (patch) | |
| tree | ca7e32dcbffa4f5b9922327347d70209139be01b /src/drivers/intel/fsp2_0/hob_display.c | |
| parent | ac3b0a6e9f78cf7c4f2b32a6f97a42e7528aedd6 (diff) | |
drivers/intel/fsp2_0: Verify HOBs returned by FspMemoryInit
Verify that FSP is properly returning:
* HOB list pointer
* FSP_BOOTLOADER_TOLUM_HOB
* FSP_RESERVED_MEMORY_RESOURCE_HOB
TEST=Build and run on Galileo Gen2
Change-Id: I23005d10f7f3ccf06a2e29dab5fa11c7ed79f187
Signed-off-by: Lee Leahy <leroy.p.leahy@intel.com>
Reviewed-on: https://review.coreboot.org/15850
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/drivers/intel/fsp2_0/hob_display.c')
| -rw-r--r-- | src/drivers/intel/fsp2_0/hob_display.c | 22 |
1 files changed, 1 insertions, 21 deletions
diff --git a/src/drivers/intel/fsp2_0/hob_display.c b/src/drivers/intel/fsp2_0/hob_display.c index 048d8606e4..39a9d17de7 100644 --- a/src/drivers/intel/fsp2_0/hob_display.c +++ b/src/drivers/intel/fsp2_0/hob_display.c @@ -47,11 +47,6 @@ static const uint8_t bootloader_temp_memory_guid[16] = { 0x89, 0x85, 0xb9, 0xd4, 0xf3, 0xb3, 0xf6, 0x4e }; -static const uint8_t bootloader_tolum_guid[16] = { - 0x56, 0x4f, 0xff, 0x73, 0x8e, 0xaa, 0x51, 0x44, - 0xb3, 0x16, 0x36, 0x35, 0x36, 0x67, 0xad, 0x44, -}; - static const uint8_t empty_guid[16] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; @@ -78,7 +73,7 @@ struct guid_name_map { static const struct guid_name_map guid_names[] = { { bootloader_temp_memory_guid, "FSP_BOOTLOADER_TEMP_MEMORY_HOB_GUID" }, - { bootloader_tolum_guid, "BOOTLOADER_TOLUM" }, + { fsp_bootloader_tolum_guid, "BOOTLOADER_TOLUM" }, { empty_guid, "No GUID specified" }, { fsp_info_header_guid, "FSP_INFO_HEADER_GUID" }, { fsp_reserved_memory_guid, "FSP_RESERVED_MEMORY" }, @@ -88,21 +83,6 @@ static const struct guid_name_map guid_names[] = { { tseg_guid, "TSEG" }, }; -void fsp_print_guid(const void *base) -{ - uint32_t big; - uint16_t mid[2]; - - const uint8_t *id = base; - big = read32(id + 0); - mid[0] = read16(id + 4); - mid[1] = read16(id + 6); - - printk(BIOS_SPEW, "%08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x", - big, mid[0], mid[1], - id[8], id[9], id[10], id[11], id[12], id[13], id[14], id[15]); -} - static const char *resource_name(enum resource_type type) { if (type >= ARRAY_SIZE(resource_names)) |