diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-17 11:23:32 -0700 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-17 22:13:34 +0100 |
| commit | 216712ae01993e83265470de1e29744a0970e4fa (patch) | |
| tree | 443adb76e3aa160cc57288a3b8227c65c2dd1926 /src/drivers/intel/fsp1_1/include/fsp | |
| parent | 6ef5192627b07662e641feb5049f4183edde9105 (diff) | |
drivers/intel/fsp1_1: Fix issues detected by checkpatch
Fix the following error and warnings detected by checkpatch.pl:
ERROR: "foo * bar" should be "foo *bar"
WARNING: line over 80 characters
WARNING: else is not generally useful after a break or return
WARNING: braces {} are not necessary for single statement blocks
WARNING: suspect code indent for conditional statements (16, 32)
WARNING: Comparisons should place the constant on the right side of the test
TEST=Build and run on Galileo Gen2
Change-Id: I9f56c0b0e3baf84989411e4a4b98f935725c013f
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18886
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Diffstat (limited to 'src/drivers/intel/fsp1_1/include/fsp')
| -rw-r--r-- | src/drivers/intel/fsp1_1/include/fsp/util.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/drivers/intel/fsp1_1/include/fsp/util.h b/src/drivers/intel/fsp1_1/include/fsp/util.h index eea0c33a76..32ac99ee28 100644 --- a/src/drivers/intel/fsp1_1/include/fsp/util.h +++ b/src/drivers/intel/fsp1_1/include/fsp/util.h @@ -92,12 +92,11 @@ int fsp_relocate(struct prog *fsp_relocd, const struct region_device *fsp_src); extern void *FspHobListPtr; #endif -/* TODO: Remove the EFI types and decorations from coreboot implementations. */ -VOID * EFIAPI get_hob_list(VOID); -VOID * EFIAPI get_next_hob(UINT16 type, CONST VOID *hob_start); -VOID * EFIAPI get_first_hob(UINT16 type); -VOID * EFIAPI get_next_guid_hob(CONST EFI_GUID * guid, CONST VOID *hob_start); -VOID * EFIAPI get_first_guid_hob(CONST EFI_GUID * guid); +void *get_hob_list(void); +void *get_next_hob(uint16_t type, const void *hob_start); +void *get_first_hob(uint16_t type); +void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start); +void *get_first_guid_hob(const EFI_GUID *guid); /* * Writes number_of_bytes data bytes from buffer to the console. @@ -106,6 +105,7 @@ VOID * EFIAPI get_first_guid_hob(CONST EFI_GUID * guid); * If number_of_bytes is zero, don't output any data but instead wait until * the console has output all data, then return 0. */ -size_t EFIAPI fsp_write_line(uint8_t *buffer, size_t number_of_bytes); +__attribute__((cdecl)) size_t fsp_write_line(uint8_t *buffer, + size_t number_of_bytes); #endif /* FSP1_1_UTIL_H */ |