aboutsummaryrefslogtreecommitdiff
path: root/src/drivers/i2c
diff options
context:
space:
mode:
authorSergii Dmytruk <sergii.dmytruk@3mdeb.com>2022-10-29 16:57:07 +0300
committerFelix Held <felix-coreboot@felixheld.de>2022-12-05 14:46:43 +0000
commit0a89d5237edcec3015363e9a7a3bd8b014fec500 (patch)
tree71186da3863f0fc295ac60b60344f3c6e801eb0a /src/drivers/i2c
parent2393ad0bfb1cd23a0524e7b02a0fd75aff3bf274 (diff)
security/tpm: remove tis_close()
This function was never called from outside of drivers and src/drivers/pc80/tpm/tis.c was the only one doing it in a questionable way. tpm_vendor_cleanup() also isn't needed as one of tis_close() functions was its only caller. Change-Id: I9df76adfc21fca9fa1d1af7c40635ec0684ceb0f Ticket: https://ticket.coreboot.org/issues/433 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/68989 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/drivers/i2c')
-rw-r--r--src/drivers/i2c/tpm/cr50.c4
-rw-r--r--src/drivers/i2c/tpm/tis.c10
-rw-r--r--src/drivers/i2c/tpm/tis_atmel.c5
-rw-r--r--src/drivers/i2c/tpm/tpm.c5
-rw-r--r--src/drivers/i2c/tpm/tpm.h2
5 files changed, 0 insertions, 26 deletions
diff --git a/src/drivers/i2c/tpm/cr50.c b/src/drivers/i2c/tpm/cr50.c
index b5cb32ce39..42eeff4b74 100644
--- a/src/drivers/i2c/tpm/cr50.c
+++ b/src/drivers/i2c/tpm/cr50.c
@@ -494,10 +494,6 @@ int tpm_vendor_init(struct tpm_chip *chip, unsigned int bus, uint32_t dev_addr)
return 0;
}
-void tpm_vendor_cleanup(struct tpm_chip *chip)
-{
-}
-
enum cb_err tis_vendor_write(unsigned int addr, const void *buffer, size_t bytes)
{
return cr50_i2c_write(addr & 0xff, buffer, bytes) ? CB_ERR : CB_SUCCESS;
diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c
index ea8cf3de70..9e2052ebf0 100644
--- a/src/drivers/i2c/tpm/tis.c
+++ b/src/drivers/i2c/tpm/tis.c
@@ -39,16 +39,6 @@ int tis_open(void)
return 0;
}
-int tis_close(void)
-{
- if (chip.is_open) {
- tpm_vendor_cleanup(&chip);
- chip.is_open = 0;
- }
-
- return 0;
-}
-
int tis_init(void)
{
return tpm_vendor_probe(CONFIG_DRIVER_TPM_I2C_BUS,
diff --git a/src/drivers/i2c/tpm/tis_atmel.c b/src/drivers/i2c/tpm/tis_atmel.c
index 3a87dec698..669ac68f6c 100644
--- a/src/drivers/i2c/tpm/tis_atmel.c
+++ b/src/drivers/i2c/tpm/tis_atmel.c
@@ -27,11 +27,6 @@ int tis_open(void)
return 0;
}
-int tis_close(void)
-{
- return 0;
-}
-
int tis_init(void)
{
return 0;
diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c
index 840b947ee7..606f14d07c 100644
--- a/src/drivers/i2c/tpm/tpm.c
+++ b/src/drivers/i2c/tpm/tpm.c
@@ -550,8 +550,3 @@ out_err:
release_locality(chip, 0, 1);
return -1;
}
-
-void tpm_vendor_cleanup(struct tpm_chip *chip)
-{
- release_locality(chip, chip->vendor.locality, 1);
-}
diff --git a/src/drivers/i2c/tpm/tpm.h b/src/drivers/i2c/tpm/tpm.h
index eb4fef1167..868b306c36 100644
--- a/src/drivers/i2c/tpm/tpm.h
+++ b/src/drivers/i2c/tpm/tpm.h
@@ -61,6 +61,4 @@ int tpm_vendor_probe(unsigned int bus, uint32_t addr);
int tpm_vendor_init(struct tpm_chip *chip, unsigned int bus, uint32_t dev_addr);
-void tpm_vendor_cleanup(struct tpm_chip *chip);
-
#endif /* __DRIVERS_TPM_SLB9635_I2C_TPM_H__ */