diff options
| author | Karthikeyan Ramasubramanian <kramasub@google.com> | 2020-11-02 16:26:52 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-11-09 07:24:13 +0000 |
| commit | d1c0f958d1986a94ac55ae1d196ba286c311b90f (patch) | |
| tree | 2dbba3c69328215132f5eeaa32cc221007bb9dec /src/drivers/i2c/gpiomux | |
| parent | 04582e900102357056aa218e5a413edb52409e87 (diff) | |
acpi: Call acpi_fill_ssdt() only for enabled devices
Individual drivers check whether the concerned device is enabled before
filling in the SSDT. Move the check before calling acpi_fill_ssdt() and
remove the check in the individual drivers.
BUG=None
TEST=util/abuild/abuild
Change-Id: Ib042bec7e8c68b38fafa60a8e965d781bddcd1f0
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47148
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Christian Walter <christian.walter@9elements.com>
Diffstat (limited to 'src/drivers/i2c/gpiomux')
| -rw-r--r-- | src/drivers/i2c/gpiomux/bus/bus.c | 2 | ||||
| -rw-r--r-- | src/drivers/i2c/gpiomux/mux/mux.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 66aef8e8c0..0bcf36a3f4 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -22,7 +22,7 @@ static void i2c_gpiomux_bus_fill_ssdt(const struct device *dev) const char *scope = acpi_device_scope(dev); const char *path = acpi_device_path(dev); - if (!dev || !dev->enabled || !scope || !path) + if (!dev || !scope || !path) return; /* Device */ diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 66c8cc5cc3..c1ae758226 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -27,7 +27,7 @@ static void i2c_gpiomux_mux_fill_ssdt(const struct device *dev) struct acpi_gpio_res_params param[MAX_NUM_MUX_GPIOS]; int i; - if (!dev->enabled || !scope || !path) + if (!scope || !path) return; /* Device */ |