summaryrefslogtreecommitdiff
path: root/src/drivers/genesyslogic/gl9763e/gl9763e.h
diff options
context:
space:
mode:
authorYu-Ping Wu <yupingso@chromium.org>2024-07-18 14:41:49 +0800
committerYu-Ping Wu <yupingso@google.com>2024-07-23 07:54:39 +0000
commitd8bed2d001e8882850643230a45a7dc362e8e368 (patch)
treebace8db529bfb7c0d98fce829a37b6aaeb4fbfc9 /src/drivers/genesyslogic/gl9763e/gl9763e.h
parent9b2d995bdbef8fd5df5d04ed80f7fb96382e968a (diff)
drivers/pc80/rtc/mc146818rtc: Add assertion of bank selection for AMD
As described in CB:83495, in AMD platforms, the bit 4 of CMOS Register A is bank selection. Since the MC146818 driver accesses VBNV via Bank 0, the value set in cmos_init() must not contain that bit. To prevent RTC_FREQ_SELECT_DEFAULT from being incorrectly modified, add an static assertion about the bank selection for AMD. Note that the kernel driver also ensures RTC_AMD_BANK_SELECT isn't set for AMD [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/rtc/rtc-mc146818-lib.c?id=3ae8fd4157 BUG=b:346716300 TEST=none BRANCH=skyrim Change-Id: I6122201914c40604f86dcca6025b55c595ef609e Signed-off-by: Yu-Ping Wu <yupingso@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83537 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Diffstat (limited to 'src/drivers/genesyslogic/gl9763e/gl9763e.h')
0 files changed, 0 insertions, 0 deletions