diff options
| author | Nico Huber <nico.h@gmx.de> | 2020-04-05 13:55:12 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-04-10 11:25:04 +0000 |
| commit | a461b694a6c0468cd679628aeebf83437027fb45 (patch) | |
| tree | 6ba4647074e37d7580ab85683c8aa40358246e4c /src/drivers/generic | |
| parent | 9734325f4568c19d1ffc392084aa431a810a0709 (diff) | |
Drop unnecessary DEVICE_NOOP entries
Providing an explicit no-op function pointer is only necessary for
`.read_resources` and `.set_resources`. All other device-operation
pointers are optional and can be NULL.
Change-Id: I3d139f7be86180558cabec04b8566873062e33be
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40206
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/drivers/generic')
| -rw-r--r-- | src/drivers/generic/adau7002/adau7002.c | 1 | ||||
| -rw-r--r-- | src/drivers/generic/generic/generic.c | 1 | ||||
| -rw-r--r-- | src/drivers/generic/gpio_keys/gpio_keys.c | 1 | ||||
| -rw-r--r-- | src/drivers/generic/gpio_regulator/gpio_regulator.c | 1 | ||||
| -rw-r--r-- | src/drivers/generic/ioapic/ioapic.c | 1 | ||||
| -rw-r--r-- | src/drivers/generic/max98357a/max98357a.c | 1 |
6 files changed, 0 insertions, 6 deletions
diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c index d026ffd344..97bd37d871 100644 --- a/src/drivers/generic/adau7002/adau7002.c +++ b/src/drivers/generic/adau7002/adau7002.c @@ -57,7 +57,6 @@ static const char *adau7002_acpi_name(const struct device *dev) static struct device_operations adau7002_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = adau7002_acpi_name, .acpi_fill_ssdt = adau7002_fill_ssdt, diff --git a/src/drivers/generic/generic/generic.c b/src/drivers/generic/generic/generic.c index 5666ee4157..d4de6c7583 100644 --- a/src/drivers/generic/generic/generic.c +++ b/src/drivers/generic/generic/generic.c @@ -70,7 +70,6 @@ static const char *generic_dev_acpi_name(const struct device *dev) static struct device_operations generic_dev_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, .acpi_name = generic_dev_acpi_name, .acpi_fill_ssdt = generic_dev_fill_ssdt_generator, }; diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index e2310a1c31..5a74c6409b 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -104,7 +104,6 @@ static const char *gpio_keys_acpi_name(const struct device *dev) static struct device_operations gpio_keys_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, .acpi_name = gpio_keys_acpi_name, .acpi_fill_ssdt = gpio_keys_fill_ssdt_generator, }; diff --git a/src/drivers/generic/gpio_regulator/gpio_regulator.c b/src/drivers/generic/gpio_regulator/gpio_regulator.c index 253a2fa633..7041aa0e7c 100644 --- a/src/drivers/generic/gpio_regulator/gpio_regulator.c +++ b/src/drivers/generic/gpio_regulator/gpio_regulator.c @@ -61,7 +61,6 @@ static const char *gpio_regulator_acpi_name(const struct device *dev) static struct device_operations gpio_regulator_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, .acpi_name = gpio_regulator_acpi_name, .acpi_fill_ssdt = gpio_regulator_fill_ssdt_generator, }; diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c index b09e8a6c04..b2c4bb60b1 100644 --- a/src/drivers/generic/ioapic/ioapic.c +++ b/src/drivers/generic/ioapic/ioapic.c @@ -96,7 +96,6 @@ static void ioapic_read_resources(struct device *dev) static struct device_operations ioapic_operations = { .read_resources = ioapic_read_resources, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, .init = ioapic_init, }; diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c index d1c4978398..0a29367498 100644 --- a/src/drivers/generic/max98357a/max98357a.c +++ b/src/drivers/generic/max98357a/max98357a.c @@ -72,7 +72,6 @@ static const char *max98357a_acpi_name(const struct device *dev) static struct device_operations max98357a_ops = { .read_resources = DEVICE_NOOP, .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, #if CONFIG(HAVE_ACPI_TABLES) .acpi_name = max98357a_acpi_name, .acpi_fill_ssdt = max98357a_fill_ssdt, |