diff options
| author | Nico Huber <nico.h@gmx.de> | 2022-06-24 22:07:42 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-06-27 13:53:38 +0000 |
| commit | f708b058e8f2c1a5c2a6fb16238b19f73735af46 (patch) | |
| tree | 8ba04e70d9ab67d1cedc2fb7dfc3c9bc0037804f /src/device | |
| parent | 054ff5e9231a05411f660067c6ce33cd67d0896a (diff) | |
allocator_v4: Drop spurious rule from comment
The comment said special care needs to be taken if a resource cannot
be allocated. However, the opposite seems true: There is nothing to
be done, we simply leave the resource w/o the IORESOURCE_ASSIGNED
flag. There's also no code to be found that would currently do some-
thing special. allocate_child_resources() directly continues with
the next resource after printing an error.
Change-Id: I21acbc891ea4dfb62decf9abe0ace91016486116
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65412
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/device')
| -rw-r--r-- | src/device/resource_allocator_v4.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index 6f8159e1b1..88f21f8a9f 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -648,9 +648,6 @@ static void allocate_domain_resources(const struct device *domain) * * Some rules that are followed by the resource allocator: * - Allocate resource locations for every device as long as the requirements can be satisfied. - * - If a resource cannot be allocated any address space, then that resource needs to be - * properly updated to ensure that it does not incorrectly overlap some address space reserved - * for a different purpose. * - Don't overlap with resources in fixed locations. * - Don't overlap and follow the rules of bridges -- downstream devices of bridges should use * parts of the address space allocated to the bridge. |