diff options
author | Nico Huber <nico.h@gmx.de> | 2020-05-25 00:03:14 +0200 |
---|---|---|
committer | Martin L Roth <gaumless@gmail.com> | 2022-09-04 16:35:22 +0000 |
commit | 526c64249a0a0c7b83d1914b88d4f938ede7dc1c (patch) | |
tree | 639322f2e32b0c11e629cc329e16c5c681c54781 /src/device | |
parent | 38688519cf4bca485c41b48ac5c0cc334daa8ba7 (diff) |
allocator_v4: Introduce RESOURCE_ALLOCATION_TOP_DOWN
Add option to resource allocator v4 that restores the top-down
allocation approach at the domain level.
This makes it easier to handle 64-bit resources natively. With
the top-down approach, resources that can be placed either above
or below 4G would be placed above, to save precious space below
the 4G boundary.
Change-Id: Iaf463d3e6b37d52e46761d8e210034fded58a8a4
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41957
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Diffstat (limited to 'src/device')
-rw-r--r-- | src/device/Kconfig | 5 | ||||
-rw-r--r-- | src/device/resource_allocator_v4.c | 5 |
2 files changed, 9 insertions, 1 deletions
diff --git a/src/device/Kconfig b/src/device/Kconfig index 6f4a24ef1a..af9beb32f5 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -933,6 +933,11 @@ config RESOURCE_ALLOCATOR_V4 ranges for allocating resources. This allows allocation of resources above 4G boundary as well. +config RESOURCE_ALLOCATION_TOP_DOWN + bool "Allocate resources from top down" + default y + depends on RESOURCE_ALLOCATOR_V4 + config XHCI_UTILS def_bool n help diff --git a/src/device/resource_allocator_v4.c b/src/device/resource_allocator_v4.c index 2b62fc8e2f..222f1e9a47 100644 --- a/src/device/resource_allocator_v4.c +++ b/src/device/resource_allocator_v4.c @@ -372,6 +372,9 @@ static void print_resource_ranges(const struct device *dev, const struct memrang static void allocate_child_resources(struct bus *bus, struct memranges *ranges, unsigned long type_mask, unsigned long type_match) { + const bool allocate_top_down = + bus->dev->path.type == DEVICE_PATH_DOMAIN && + CONFIG(RESOURCE_ALLOCATION_TOP_DOWN); struct resource *resource = NULL; const struct device *dev; @@ -381,7 +384,7 @@ static void allocate_child_resources(struct bus *bus, struct memranges *ranges, continue; if (memranges_steal(ranges, resource->limit, resource->size, resource->align, - type_match, &resource->base) == false) { + type_match, &resource->base, allocate_top_down) == false) { printk(BIOS_ERR, " ERROR: Resource didn't fit!!! "); printk(BIOS_DEBUG, " %s %02lx * size: 0x%llx limit: %llx %s\n", dev_path(dev), resource->index, |