summaryrefslogtreecommitdiff
path: root/src/device
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2019-01-03 10:23:28 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-01-07 10:28:59 +0000
commit0f8b8d920c2f060bbe7a9139fde823e3b2e875d7 (patch)
tree8d53a881ad95ab6a4e9e5ded8622d99fd2b0b360 /src/device
parentf212cf3506a9ad3d699a4afe148bfd554932f7b8 (diff)
src: Move constant to the right side of comparison
Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/27015 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/device')
-rw-r--r--src/device/pci_class.c2
-rw-r--r--src/device/pci_rom.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/device/pci_class.c b/src/device/pci_class.c
index b2f5ff765c..1326b2c0cc 100644
--- a/src/device/pci_class.c
+++ b/src/device/pci_class.c
@@ -263,7 +263,7 @@ const char *get_pci_subclass_name(struct device *dev)
subclass_name = "???";
class_entry = get_pci_class_entry(dev);
subclass_entry = class_entry ? class_entry->subclass_list : NULL;
- if (NULL != subclass_entry) {
+ if (subclass_entry != NULL) {
subclass_list_end =
&subclass_entry[class_entry->subclass_entries];
while (subclass_list_end > subclass_entry) {
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 65989d4724..82d9a3056a 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -150,7 +150,7 @@ struct rom_header *pci_rom_load(struct device *dev,
* whether the ROM image is for a VGA device because some
* devices have a mismatch between the hardware and the ROM.
*/
- if (PCI_CLASS_DISPLAY_VGA == (dev->class >> 8)) {
+ if ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA) {
#if !IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)
extern struct device *vga_pri; /* Primary VGA device (device.c). */
if (dev != vga_pri) return NULL; /* Only one VGA supported. */