diff options
author | Nico Huber <nico.h@gmx.de> | 2023-05-12 15:46:24 +0200 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2023-05-17 11:23:59 +0000 |
commit | 6a07db21b12b08c7b975921f2ee1196dd0ec92b3 (patch) | |
tree | 3b6fceda427aa70be42058500f337d39610bf09e /src/device/smbus_ops.c | |
parent | feba51ba17b24e32fd9442310c05aaec2aa0de5f (diff) |
console: Add format-checking __printf() to die()
Code changes are necessary because `-Wformat` warns about empty
format strings by default.
Change-Id: Ic8021b70f4cd4875b06f196f88b84940c9a79fe0
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75147
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/device/smbus_ops.c')
-rw-r--r-- | src/device/smbus_ops.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/device/smbus_ops.c b/src/device/smbus_ops.c index 12aaf998c9..d08965c7e0 100644 --- a/src/device/smbus_ops.c +++ b/src/device/smbus_ops.c @@ -8,11 +8,8 @@ struct bus *get_pbus_smbus(struct device *dev) { struct bus *const pbus = i2c_link(dev); - if (!pbus->dev->ops->ops_smbus_bus) { - printk(BIOS_ALERT, "%s Cannot find SMBus bus operations", - dev_path(dev)); - die(""); - } + if (!pbus->dev->ops->ops_smbus_bus) + die("%s Cannot find SMBus bus operations", dev_path(dev)); return pbus; } |