summaryrefslogtreecommitdiff
path: root/src/device/pnp_device.c
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2016-12-13 08:03:10 +0100
committerMartin Roth <martinroth@google.com>2016-12-15 04:11:06 +0100
commitf1f322b1a883e3d50a1907e29b5aa333a0f795a8 (patch)
tree2956a9fc585c93f0e1d7cda88550d1a1bd3c790f /src/device/pnp_device.c
parent6bc44169680816e137ad9450f404c8463e7eb9d9 (diff)
pcf8523: Fix wrong initialization of several registers
In the case where the RTC is initialized after the battery is completely drained the bits for power_mode and cof_selection are set up with wrongly applied masks. In the case where the RTC is re-initialized again with no power-loss after the last initialization the bits for cap_sel, power_mode and cof_selection are not shifted to the right position. Both errors lead to a wrong initialization of the RTC and in turn to a way larger current consumption (instead of 120 nA the RTC current rises to over 2 µA). This patch fixes both errors and the current consumption is in the right range again. TEST=booted mc_bdx1 and verified current consumption of RTC Change-Id: I8594f6ac121a175844393952db2169dbc5cbd2b2 Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/17829 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/device/pnp_device.c')
0 files changed, 0 insertions, 0 deletions