diff options
author | Furquan Shaikh <furquan@chromium.org> | 2017-10-15 15:27:32 -0700 |
---|---|---|
committer | Aaron Durbin <adurbin@chromium.org> | 2017-10-17 14:45:12 +0000 |
commit | efe1e2d2d458897995552c173ad826b52afd768d (patch) | |
tree | a54707ee5489ba6787e37aae747236cd1363e914 /src/device/pcix_device.c | |
parent | e7d9248d9fb90d2ea296fd922f8574909d2580af (diff) |
soc/intel/common/block/pmc: Move pmc_disable_all_gpe to romstage
Instead of disabling all GPEs during PMC init in bootblock, this
change moves it to pmc_fill_power_state which allows romstage to
correctly fill up GPE_EN registers in chipset_power_state. This is
essential for correctly identifying the wake source.
Disabling all GPEs was added recently in change 74145f76
(intel/common/pmc: Disable all GPEs during pmc_init) because keeping
GPEs enabled in coreboot while enabling SMI could lead to
side-effects as explained in the change. Moving pmc_disable_all_gpe to
pmc_fill_power_state should be safe as that happens before SMI is
enabled in coreboot.
TEST=Verified that GPE-based wake source is correctly
identified. Also, no issues observed while resuming from S3.
Change-Id: I8e992ad09ffdefba62de11fa572e783715776bf1
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/22033
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/device/pcix_device.c')
0 files changed, 0 insertions, 0 deletions