device: Tidy up add_more_links()

- Add documentation comment
- Use 'unsigned int' to make checkpatch happy
- Return early if no more links need to be added
- Add error handling if malloc fails
- Clean up whitespace

Change-Id: I70976ee2539b058721d0ae3c15edf279253cd9b7
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1229634
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33238
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

1 files changed, 16 insertions, 5 deletions

diff --git a/src/device/device_util.c b/src/device/device_util.c
index e2370a1cce..11954a1982 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -654,7 +654,13 @@ bool dev_is_active_bridge(struct device *dev)
 	return 0;
 }
 
-void add_more_links(struct device *dev, unsigned total_links)
+/**
+ * Ensure the device has a minimum number of bus links.
+ *
+ * @param dev The device to add links to.
+ * @param total_links The minimum number of links to have.
+ */
+void add_more_links(struct device *dev, unsigned int total_links)
 {
 	struct bus *link, *last = NULL;
 	int link_num = -1;
@@ -668,15 +674,20 @@ void add_more_links(struct device *dev, unsigned total_links)
 	if (last) {
 		int links = total_links - (link_num + 1);
 		if (links > 0) {
-			link = malloc(links*sizeof(*link));
+			link = malloc(links * sizeof(*link));
 			if (!link)
 				die("Couldn't allocate more links!\n");
-			memset(link, 0, links*sizeof(*link));
+			memset(link, 0, links * sizeof(*link));
 			last->next = link;
+		} else {
+			/* No more links to add */
+			return;
 		}
 	} else {
-		link = malloc(total_links*sizeof(*link));
-		memset(link, 0, total_links*sizeof(*link));
+		link = malloc(total_links * sizeof(*link));
+		if (!link)
+			die("Couldn't allocate more links!\n");
+		memset(link, 0, total_links * sizeof(*link));
 		dev->link_list = link;
 	}