diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2023-03-07 23:56:09 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-08 23:00:02 +0000 |
| commit | 8cbd216836b5cee2d96243bd395ebe84caa02a1a (patch) | |
| tree | c6718862cd3b6e35db8323fa3e3bf086319bc21f /src/cpu | |
| parent | 07a56e02bfe9616d2192d757ddb32fc1bcaa8a9e (diff) | |
cpu/x86,amd: drop unused LOGICAL_CPUS Kconfig symbol
The LOGICAL_CPUS Kconfig option is always true and also not user-
configurable, so it can be dropped.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie4866de003058ec0f99495b405e26dfd7ba1fa28
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73553
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Diffstat (limited to 'src/cpu')
| -rw-r--r-- | src/cpu/amd/pi/00730F01/model_16_init.c | 20 | ||||
| -rw-r--r-- | src/cpu/x86/Kconfig | 4 |
2 files changed, 9 insertions, 15 deletions
diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c index caf4647467..d7c23daf10 100644 --- a/src/cpu/amd/pi/00730F01/model_16_init.c +++ b/src/cpu/amd/pi/00730F01/model_16_init.c @@ -25,20 +25,18 @@ static void model_16_init(struct device *dev) /* zero the machine check error status registers */ mca_clear_status(); - if (CONFIG(LOGICAL_CPUS)) { - siblings = get_cpu_count() - 1; // minus BSP + siblings = get_cpu_count() - 1; // minus BSP - if (siblings > 0) { - msr = rdmsr_amd(CPU_ID_FEATURES_MSR); - msr.lo |= 1 << 28; - wrmsr_amd(CPU_ID_FEATURES_MSR, msr); + if (siblings > 0) { + msr = rdmsr_amd(CPU_ID_FEATURES_MSR); + msr.lo |= 1 << 28; + wrmsr_amd(CPU_ID_FEATURES_MSR, msr); - msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR); - msr.hi |= 1 << (33 - 32); - wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr); - } - printk(BIOS_DEBUG, "siblings = %02d, ", siblings); + msr = rdmsr_amd(CPU_ID_EXT_FEATURES_MSR); + msr.hi |= 1 << (33 - 32); + wrmsr_amd(CPU_ID_EXT_FEATURES_MSR, msr); } + printk(BIOS_DEBUG, "siblings = %02d, ", siblings); /* DisableCf8ExtCfg */ msr = rdmsr(NB_CFG_MSR); diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index d95e6cc4c3..50766cdac1 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -126,10 +126,6 @@ config SETUP_XIP_CACHE non-eviction mode and therefore need to be careful to avoid eviction. -config LOGICAL_CPUS - bool - default y - config HAVE_SMI_HANDLER bool default n |