aboutsummaryrefslogtreecommitdiff
path: root/src/cpu/x86
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2021-09-21 10:56:35 -0600
committerFelix Held <felix-coreboot@felixheld.de>2021-09-24 17:11:54 +0000
commit333652c5b2dd3291a73f922e0b86c3ab9612f4b1 (patch)
tree46ac8abe4ad1a0db3a3b9709272884820c0393c9 /src/cpu/x86
parent5ef58735764c2eb8d3593b61f9dd122f2f3d6e44 (diff)
cpu/x86/mp_init: Add comment to smm_do_relocation
It took me a while to understand the SMM set up flow. This adds a clarifying comment. BUG=b:194391185, b:179699789 TEST=None Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I9c73e416b8c583cf870e7a29b0bd7dcc99c2f5f4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57858 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Diffstat (limited to 'src/cpu/x86')
-rw-r--r--src/cpu/x86/mp_init.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index aa037f3001..f54a7b714d 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -714,6 +714,11 @@ static void smm_enable(void)
mp_state.do_smm = 1;
}
+/*
+ * This code is built as part of ramstage, but it actually runs in SMM. This
+ * means that ENV_SMM is 0, but we are actually executing in the environment
+ * setup by the smm_stub.
+ */
static void asmlinkage smm_do_relocation(void *arg)
{
const struct smm_module_params *p;