summaryrefslogtreecommitdiff
path: root/src/cpu/x86
diff options
context:
space:
mode:
authorRonald G. Minnich <rminnich@chromium.org>2012-06-05 14:08:10 -0700
committerRonald G. Minnich <rminnich@gmail.com>2012-07-24 06:54:59 +0200
commit305b19dd7a8394132216f51acf2bc073c7c42397 (patch)
tree6611512d566170b780f27ba18abf8b4187f6a957 /src/cpu/x86
parent28190ce4de4667ab79e415441f791dba04022f0b (diff)
Remove code that enables/disables VMX in coreboot on chromebooks.
There are several reasons for this: 1. It's a core setting, not a platform setting, which is bizarre. But, we disable vmx via an SMI, and that only happens on core 0. Hence, the code did not correctly make the same settings on all cores- one had them disabled, the others were in an unknown state. When (e.g.) kvm started on a vmx-enabled core, then moved to a vmx-disabled core, the processor would reset *very* quickly. Changing this would be messy. 2. On the CPU on link, there is something about trying to set the lock bit that is getting a GPF. 3. It's the wrong place and time to set it. Once controlled, they can't be changed in the kernel. The kernel is what should control this feature, not the BIOS, as we have learned time and time again. If somebody is in as root and can start a VM, you have a lot more to worry about than someone starting a guest virtual machine. Change-Id: I4f36093f1b68207251584066ccb9a6bcfeec767e Signed-off-by: Ronald G. Minnich <rminnich@chromium.org> Reviewed-on: http://review.coreboot.org/1276 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/cpu/x86')
0 files changed, 0 insertions, 0 deletions