summaryrefslogtreecommitdiff
path: root/src/cpu/samsung
diff options
context:
space:
mode:
authorDavid Hendricks <dhendrix@chromium.org>2013-04-07 17:38:32 -0700
committerRonald G. Minnich <rminnich@gmail.com>2013-04-08 18:30:03 +0200
commitc7e5d798420bb00f2c1853ca6abc11a7ee027886 (patch)
treedd34dba5508a75e7e58b08f48385f64e495062bc /src/cpu/samsung
parent0c8b7d1ac272d5578e61c260a14f4fabbf3f53eb (diff)
exynos5250: add missing address-of operator in UART driver
This adds a missing address-of operator. This was a subtle bug that didn't seem to cause problems at first since the serial console appeared to work. However it caused an imprecise external abort which became apparent later on when aborts were unmasked in the kernel via the CPSR_A bit. (credit goes to Gabe Black for finding this) Signed-off-by: Gabe Black <gabeblack@chromium.org> Signed-off-by: David Hendricks <dhendrix@chromium.org> Change-Id: I80a33b147d92d559fa8fefbe7d5642235deb9aea Reviewed-on: http://review.coreboot.org/3038 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/cpu/samsung')
-rw-r--r--src/cpu/samsung/exynos5250/uart.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cpu/samsung/exynos5250/uart.c b/src/cpu/samsung/exynos5250/uart.c
index d23087a8b1..75c576332f 100644
--- a/src/cpu/samsung/exynos5250/uart.c
+++ b/src/cpu/samsung/exynos5250/uart.c
@@ -185,7 +185,7 @@ static void exynos5_uart_tx_byte(unsigned char data)
struct s5p_uart *uart = (struct s5p_uart *)base_port;
/* wait for room in the tx FIFO */
- while ((readl(uart->ufstat) & TX_FIFO_FULL_MASK)) {
+ while ((readl(&uart->ufstat) & TX_FIFO_FULL_MASK)) {
if (exynos5_uart_err_check(1))
return;
}