summaryrefslogtreecommitdiff
path: root/src/cpu/samsung/exynos5250
diff options
context:
space:
mode:
authorDavid Hendricks <dhendrix@chromium.org>2013-01-09 18:06:41 -0800
committerRonald G. Minnich <rminnich@gmail.com>2013-01-10 05:56:30 +0100
commit5f6d857deaac61b53cfa4e8cbc0abaa63e14fd9b (patch)
treec12ee90d51f0bc5b0a43b0a9eeeb1b667ecd0dce /src/cpu/samsung/exynos5250
parent27094b0afe25caf38e323d5f350be7d89aace366 (diff)
exynos5250: clean-ups for clock_init
This does some clean-up for the exynos5250 clock_init.c: - No global data. - Remove some unused #includes - Hard-code the memory type for Elpida DRAM. This will need to be fixed eventually (or the system will be unstable), but is good enough for early bring-up and until we finish other re-factoring. Change-Id: Icd2cf8ba35058cbd1131666db311dfb77ef1a160 Signed-off-by: David Hendricks <dhendrix@chromium.org> Reviewed-on: http://review.coreboot.org/2127 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/cpu/samsung/exynos5250')
-rw-r--r--src/cpu/samsung/exynos5250/clock_init.c27
1 files changed, 8 insertions, 19 deletions
diff --git a/src/cpu/samsung/exynos5250/clock_init.c b/src/cpu/samsung/exynos5250/clock_init.c
index fd2a90f815..ea91bb4355 100644
--- a/src/cpu/samsung/exynos5250/clock_init.c
+++ b/src/cpu/samsung/exynos5250/clock_init.c
@@ -22,18 +22,6 @@
* MA 02111-1307 USA
*/
-#if 0
-#include <common.h>
-#include <config.h>
-//#include <fdtdec.h>
-#include <arch/io.h>
-#include <asm/arch/board.h>
-#include <asm/arch/clk.h>
-#include <asm/arch/clock.h>
-#include <cpu/samsung/exynos5250/cpu.h>
-#include <asm/arch/gpio.h>
-#include <asm/arch-exynos/spl.h>
-#endif
#include <delay.h>
#include <stdlib.h>
#include <types.h>
@@ -51,8 +39,6 @@
#include "clock_init.h"
#include "setup.h"
-//DECLARE_GLOBAL_DATA_PTR;
-
struct arm_clk_ratios arm_clk_ratios[] = {
{
.arm_freq_mhz = 600,
@@ -585,10 +571,16 @@ struct mem_timings mem_timings[] = {
*/
#define BOARD_REV_ELPIDA_MEMORY 3
#define BOARD_REV_SAMSUNG_MEMORY 4
+
+static inline int board_get_revision(void)
+{
+ /* FIXME: yuck! */
+ return BOARD_REV_ELPIDA_MEMORY;
+}
+
static int autodetect_memory(void)
{
-// int board_rev = board_get_revision();
- int board_rev = BOARD_REV_ELPIDA_MEMORY;
+ int board_rev = board_get_revision();
if (board_rev == -1)
return -1;
@@ -749,9 +741,6 @@ struct mem_timings *clock_get_mem_timings(void)
return mem;
}
}
- /* TODO: Call panic() here */
- while (1)
- ;
return NULL;
}