diff options
| author | Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> | 2024-01-30 09:53:46 +0900 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-01-31 09:51:58 +0000 |
| commit | bfb11bec3b3fec638adf864a9b9b2cff6671fed8 (patch) | |
| tree | 0247c385cfbd79aa8496b1ddc3c3afcce1465616 /src/cpu/intel | |
| parent | f4c496d3e3e779b3d870d13e1e359a3b5f7087cb (diff) | |
include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Diffstat (limited to 'src/cpu/intel')
| -rw-r--r-- | src/cpu/intel/haswell/acpi.c | 2 | ||||
| -rw-r--r-- | src/cpu/intel/model_1067x/model_1067x_init.c | 2 | ||||
| -rw-r--r-- | src/cpu/intel/model_2065x/acpi.c | 2 | ||||
| -rw-r--r-- | src/cpu/intel/model_206ax/acpi.c | 2 | ||||
| -rw-r--r-- | src/cpu/intel/slot_1/slot_1.c | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c index 3727d8a065..c8f6a07a00 100644 --- a/src/cpu/intel/haswell/acpi.c +++ b/src/cpu/intel/haswell/acpi.c @@ -364,5 +364,5 @@ void generate_cpu_entries(const struct device *device) } struct chip_operations cpu_intel_haswell_ops = { - CHIP_NAME("Intel Haswell CPU") + .name = "Intel Haswell CPU", }; diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c index 315e7c36fc..c2019ab13b 100644 --- a/src/cpu/intel/model_1067x/model_1067x_init.c +++ b/src/cpu/intel/model_1067x/model_1067x_init.c @@ -277,5 +277,5 @@ static const struct cpu_driver driver __cpu_driver = { }; struct chip_operations cpu_intel_model_1067x_ops = { - CHIP_NAME("Intel Penryn CPU") + .name = "Intel Penryn CPU", }; diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c index d8fef628b8..2dceba1a1d 100644 --- a/src/cpu/intel/model_2065x/acpi.c +++ b/src/cpu/intel/model_2065x/acpi.c @@ -242,5 +242,5 @@ void generate_cpu_entries(const struct device *device) } struct chip_operations cpu_intel_model_2065x_ops = { - CHIP_NAME("Intel Arrandale CPU") + .name = "Intel Arrandale CPU", }; diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index f3bd67be4b..75e6755555 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -380,5 +380,5 @@ void generate_cpu_entries(const struct device *device) } struct chip_operations cpu_intel_model_206ax_ops = { - CHIP_NAME("Intel SandyBridge/IvyBridge CPU") + .name = "Intel SandyBridge/IvyBridge CPU", }; diff --git a/src/cpu/intel/slot_1/slot_1.c b/src/cpu/intel/slot_1/slot_1.c index 0f5b157eca..ed8e88c0a4 100644 --- a/src/cpu/intel/slot_1/slot_1.c +++ b/src/cpu/intel/slot_1/slot_1.c @@ -3,5 +3,5 @@ #include <device/device.h> struct chip_operations cpu_intel_slot_1_ops = { - CHIP_NAME("Slot 1 CPU") + .name = "Slot 1 CPU", }; |