diff options
author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2013-06-08 15:48:14 +0300 |
---|---|---|
committer | Nico Huber <nico.huber@secunet.com> | 2013-06-14 18:18:56 +0200 |
commit | e49679d5a1e6a6225980a9ae8455fef47e56ab12 (patch) | |
tree | 644843da8a036163ef3948b89b71fadfe3a902eb /src/cpu/intel/haswell | |
parent | f55a54257a28d4d0444baa03b5699f73fc6cd05e (diff) |
usbdebug: Drop temporary disables of log output
With this patch, output on usbdebug also includes the section of
MTRR setups for every CPU. This makes usbdebug output almost identical
with that of serial port and CBMEM console.
Tested with model_206ax. Also tested previously on model_f2x which does
not have these disable/enable calls in model_f2x_init() without detected issues.
Change-Id: Idfd0e93439907b17255633658195d698feab3895
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/3423
Reviewed-by: Aaron Durbin <adurbin@google.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/cpu/intel/haswell')
-rw-r--r-- | src/cpu/intel/haswell/haswell_init.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c index 18636b0840..0bf98ec393 100644 --- a/src/cpu/intel/haswell/haswell_init.c +++ b/src/cpu/intel/haswell/haswell_init.c @@ -438,10 +438,6 @@ static void configure_mca(void) wrmsr(IA32_MC0_STATUS + (i * 4), msr); } -#if CONFIG_USBDEBUG -static unsigned ehci_debug_addr; -#endif - static void bsp_init_before_ap_bringup(struct bus *cpu_bus) { struct device_path cpu_path; @@ -466,22 +462,11 @@ static void bsp_init_before_ap_bringup(struct bus *cpu_bus) if (info->index != 0) printk(BIOS_CRIT, "BSP index(%d) != 0!\n", info->index); -#if CONFIG_USBDEBUG - // Is this caution really needed? - if(!ehci_debug_addr) - ehci_debug_addr = get_ehci_debug(); - set_ehci_debug(0); -#endif - /* Setup MTRRs based on physical address size. */ x86_setup_fixed_mtrrs(); x86_setup_var_mtrrs(cpuid_eax(0x80000008) & 0xff, 2); x86_mtrr_check(); -#if CONFIG_USBDEBUG - set_ehci_debug(ehci_debug_addr); -#endif - /* Call through the cpu driver's initialization. */ cpu_initialize(0); } |