summaryrefslogtreecommitdiff
path: root/src/cpu/amd
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2013-12-12 06:53:05 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2013-12-13 09:07:46 +0100
commit75b68d8f5b60c62060eda1761b7a10c70b9ed8a5 (patch)
tree11031991e3ce662ba384169c8eddeff118e6abcb /src/cpu/amd
parentf95bb2d7bb6b38fba4f2c5af702e0b43da0c77ae (diff)
cpu/amd: Remove error messages on non-matching microcode patches
Microcode update file contains patches for various processor revisions, it is not an error to have those. Change-Id: Ifbca26276b66f17092afe249a2cfc229713a9fec Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/4520 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'src/cpu/amd')
-rw-r--r--src/cpu/amd/microcode/microcode.c28
1 files changed, 1 insertions, 27 deletions
diff --git a/src/cpu/amd/microcode/microcode.c b/src/cpu/amd/microcode/microcode.c
index 46d814e0c9..cdc6e4aad1 100644
--- a/src/cpu/amd/microcode/microcode.c
+++ b/src/cpu/amd/microcode/microcode.c
@@ -51,32 +51,6 @@ struct microcode {
u8 x86_code_entry[191];
};
-static int need_apply_patch(struct microcode *m, u32 equivalent_processor_rev_id)
-{
-
- if (m->processor_rev_id != equivalent_processor_rev_id) {
- printk(BIOS_ERR, "microcode: rev id (%x) does not match this patch.\n", m->processor_rev_id);
- printk(BIOS_ERR, "microcode: Not updated! Fix microcode_updates[] \n");
- return 0;
- }
- if (m->nb_dev_id) {
- //look at the device id, if not found return;
- //if(m->nb_rev_id != installed_nb_rev_id) return 0;
- }
-
- if (m->ht_io_hub_dev_id) {
- //look at the device id, if not found return;
- //if(m->ht_io_hub_rev_id != installed_ht_io_bub_rev_id) return 0;
- }
-
- if (m->x86_code_present) {
- //if(!x86_code_execute()) return 0;
- }
-
- return 1;
-}
-
-
void amd_update_microcode(void *microcode_updates, u32 equivalent_processor_rev_id)
{
u32 patch_id, new_patch_id;
@@ -93,7 +67,7 @@ void amd_update_microcode(void *microcode_updates, u32 equivalent_processor_rev_
for(c = microcode_updates; m->date_code; m = (struct microcode *)c) {
- if( need_apply_patch(m, equivalent_processor_rev_id) ) {
+ if (m->processor_rev_id == equivalent_processor_rev_id) {
//apply patch
msr.hi = 0;