diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-04-13 15:25:43 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-07-17 19:31:09 +0000 |
| commit | bebd766f165e7b3e1f6776c52067ab8998422607 (patch) | |
| tree | 65a5c5e921a79af38b93154a85c274171056c402 /src/cpu/amd/pi/Makefile.inc | |
| parent | 9de82612fe722cf3526ed508a463bfb6c9f911d0 (diff) | |
binaryPI: Disable CAR with empty stack
Calling disable_cache_as_ram() with valuables in stack is not
a stable solution, as per documentation AMD_DISABLE_STACK
should destroy stack in cache.
While we still preserve cache contents (there is wbinvd deep
inside AMD_DISABLE_STACK macro), we now actually do a stack
switch and much more closely meet the specification of CAR
teardown sequence in AGESA specifications.
We now somewhat incorrectly include files from agesa/ tree,
but the whole agesawrapper.c file removal will address the
issue of overall directory layout.
Change-Id: I2bac098099c1caffea181356c63924f4b5a93b54
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/18525
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/cpu/amd/pi/Makefile.inc')
| -rw-r--r-- | src/cpu/amd/pi/Makefile.inc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cpu/amd/pi/Makefile.inc b/src/cpu/amd/pi/Makefile.inc index ecbc386fb6..3fef7e8580 100644 --- a/src/cpu/amd/pi/Makefile.inc +++ b/src/cpu/amd/pi/Makefile.inc @@ -19,8 +19,9 @@ subdirs-$(CONFIG_CPU_AMD_PI_00660F01) += 00660F01 ramstage-$(CONFIG_SPI_FLASH) += spi.c -cpu_incs-y += $(src)/cpu/amd/pi/cache_as_ram.inc +cpu_incs-y += $(src)/cpu/amd/agesa/cache_as_ram.inc +romstage-y += romstage.c romstage-y += ../agesa/heapmanager.c ramstage-y += ../agesa/heapmanager.c ramstage-y += amd_late_init.c |