summaryrefslogtreecommitdiff
path: root/src/console
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2021-04-26 09:43:36 -0600
committerFelix Held <felix-coreboot@felixheld.de>2021-04-27 23:36:05 +0000
commit15ddb363d4d869fa1c3512e7fbf9682ec41375bf (patch)
treec7d24b05885d7523f4b947fffaa7947a5dbed795 /src/console
parentf62c49474fd6739558e308df0603350dd73b516e (diff)
mb/google/guybrush: Fix EC SCI configuration
This change fixes two problems: 1) We had the enum values for .direction and .level swapped. The naming is very confusing... 2) ESPI_SYS is not a good event to use for EC SCI. It is a level/low event that is only cleared by reading the eSPI status register 0x9C. Cezanne has added a new event source that directly exposes the SCI bit. This is the correct event source to use for EC SCI. BUG=b:186045622, b:181139095 TEST=`lpc sci` on EC console and see /proc/interrupts increase by 1 Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I764b9ec202376d5124331a320767cbf79371dc07 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52673 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com> Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/console')
0 files changed, 0 insertions, 0 deletions