diff options
author | Julius Werner <jwerner@chromium.org> | 2013-12-12 20:24:48 -0800 |
---|---|---|
committer | Isaac Christensen <isaac.christensen@se-eng.com> | 2014-09-22 18:46:57 +0200 |
commit | 64b9ca9d4eb5eccdea86d967220c67b503a4519b (patch) | |
tree | bbe6ca5da122aced6f6a6db22634c76027f34e71 /src/arch | |
parent | 406bad127bf7ac7da25261a30d239751b24e22af (diff) |
arm: Move libgcc assembly macros to arch/asm.h
libgcc/macros.h contains some useful assembly macros that are common in
Linux kernel code and facilitate things such as unified ARM/THUMB
assembly. This patch moves it to a more general place where it can be
used by other code as well.
Change-Id: If68e8930aaafa706c54cf9a156fac826b31bb193
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/182178
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit a780670def94a969829811fa8cf257f12b88f085)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6917
Tested-by: build bot (Jenkins)
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Diffstat (limited to 'src/arch')
-rw-r--r-- | src/arch/arm/armv4/Makefile.inc | 3 | ||||
-rw-r--r-- | src/arch/arm/armv4/bootblock.S | 16 | ||||
-rw-r--r-- | src/arch/arm/armv7/Makefile.inc | 2 | ||||
-rw-r--r-- | src/arch/arm/armv7/bootblock.S | 6 | ||||
-rw-r--r-- | src/arch/arm/include/arch/asm.h | 47 |
5 files changed, 58 insertions, 16 deletions
diff --git a/src/arch/arm/armv4/Makefile.inc b/src/arch/arm/armv4/Makefile.inc index d054b31e4e..aa788688d0 100644 --- a/src/arch/arm/armv4/Makefile.inc +++ b/src/arch/arm/armv4/Makefile.inc @@ -19,7 +19,8 @@ ## ############################################################################### -armv4_flags = -marm -march=armv4t -I$(src)/arch/arm/include/armv4/ +armv4_flags = -marm -march=armv4t -I$(src)/arch/arm/include/armv4/ \ + -D__COREBOOT_ARM_ARCH__=4 ############################################################################### # bootblock diff --git a/src/arch/arm/armv4/bootblock.S b/src/arch/arm/armv4/bootblock.S index 3ba2a88e26..58a34cff7e 100644 --- a/src/arch/arm/armv4/bootblock.S +++ b/src/arch/arm/armv4/bootblock.S @@ -29,19 +29,10 @@ * MA 02111-1307 USA */ -.section ".start", "a", %progbits -.globl _start -_start: b reset - .balignl 16,0xdeadbeef - -_cbfs_master_header: - /* The CBFS master header is inserted by cbfstool at the first - * aligned offset after the above anchor string is found. - * Hence, we leave some space for it. - */ - .skip 128 @ Assumes 64-byte alignment +#include <arch/asm.h> -reset: +.section ".start", "a", %progbits +ENTRY(_start) /* * Set the cpu to System mode with IRQ and FIQ disabled. Prefetch/Data * aborts may happen early and crash before the abort handlers are @@ -84,6 +75,7 @@ call_bootblock: * wrapper which is currently broken. */ bl main +ENDPROC(_start) /* we do it this way because it's a 32-bit constant and * in some cases too far away to be loaded as just an offset diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.inc index 2cc42bb63f..033d498d47 100644 --- a/src/arch/arm/armv7/Makefile.inc +++ b/src/arch/arm/armv7/Makefile.inc @@ -20,7 +20,7 @@ ############################################################################### armv7_flags = -march=armv7-a -mthumb -mthumb-interwork \ - -I$(src)/arch/arm/include/armv7/ + -I$(src)/arch/arm/include/armv7/ -D__COREBOOT_ARM_ARCH__=7 ############################################################################### # bootblock diff --git a/src/arch/arm/armv7/bootblock.S b/src/arch/arm/armv7/bootblock.S index cfe65e5393..a8d0973034 100644 --- a/src/arch/arm/armv7/bootblock.S +++ b/src/arch/arm/armv7/bootblock.S @@ -29,9 +29,10 @@ * MA 02111-1307 USA */ +#include <arch/asm.h> + .section ".start", "a", %progbits -.globl _start -_start: +ENTRY(_start) /* * Set the cpu to System mode with IRQ and FIQ disabled. Prefetch/Data * aborts may happen early and crash before the abort handlers are @@ -89,6 +90,7 @@ call_bootblock: wait_for_interrupt: wfi mov pc, lr @ back to my caller +ENDPROC(_start) /* we do it this way because it's a 32-bit constant and * in some cases too far away to be loaded as just an offset diff --git a/src/arch/arm/include/arch/asm.h b/src/arch/arm/include/arch/asm.h new file mode 100644 index 0000000000..1c3f7a21c3 --- /dev/null +++ b/src/arch/arm/include/arch/asm.h @@ -0,0 +1,47 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2013 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef __ARM_ASM_H +#define __ARM_ASM_H + +#if defined __arm__ +# define ARM(x...) x +# define THUMB(x...) +#elif defined __thumb__ +# define ARM(x...) +# define THUMB(x...) x +#else +# error Not in ARM or thumb mode! +#endif + +#define ALIGN .align 0 + +#define ENDPROC(name) \ + .type name, %function; \ + END(name) + +#define ENTRY(name) \ + .globl name; \ + ALIGN; \ + name: + +#define END(name) \ + .size name, .-name + +#endif /* __ARM_ASM_H */ |